Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Open alcs and portal document inline with standardized method #1513

Merged
merged 7 commits into from
Mar 14, 2024
Merged

Open alcs and portal document inline with standardized method #1513

merged 7 commits into from
Mar 14, 2024

Conversation

sandratoh
Copy link
Contributor

@sandratoh sandratoh commented Mar 14, 2024 •
edited
Loading

  • Update alcs CSP to allow frame plugin source from document storage
  • Update alcs openFileInline logic to open file in new window with file name as browser tab title
  • Update portal openFileWindow to use the same logic as ALCS openFileInline and also renamed it
  • Update all portal usage of util method
  • Revert backend changes done in Open portal non-decision documents in new browser tab iframe #1495 (already have filename in frontend parent wrapper)

trslater
trslater approved these changes Mar 14, 2024
View reviewed changes
Copy link
Collaborator

@trslater trslater left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@sandratoh sandratoh merged commit 215444e into develop Mar 14, 2024
3 checks passed
@sandratoh sandratoh deleted the feature/ALCS-1701 branch March 14, 2024 22:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@trslater trslater trslater approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sandratoh @trslater