Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated the new credential definition URL and identifiers #158

Merged
merged 1 commit into from
Jan 7, 2025

Conversation

arbordeleau
Copy link
Contributor

I am not sure if i needed to update somewhere else :)

@swcurran
Copy link
Contributor

swcurran commented Jan 7, 2025

That should be sufficient. I’ll likely do a follow up PR for admin purposes, but this will get the update into the wallet.

@swcurran swcurran merged commit f3568c4 into bcgov:main Jan 7, 2025
2 checks passed
@arbordeleau
Copy link
Contributor Author

Ok thank you!!

@arbordeleau
Copy link
Contributor Author

Hi! So i've been looking at the OCA and it shows 404 This page could not be found on the OCA I was wondering if it was normal?
https://bcgov.github.io/aries-oca-bundles/OCABundles/schema/bcgov-digital-trust/LTSA/NewCredCredential/demo/#identifiers

@swcurran
Copy link
Contributor

swcurran commented Jan 8, 2025

Very strange. I’m not seeing anything wrong other than that — e.g. the data is showing what I expect. However, if I go to the OCA Explorer tab and select the New Credential, I do see the display data — but with the old (no “_”) identifier. So I’m checking if it is something to do with the OCA Explorer.

@swcurran
Copy link
Contributor

swcurran commented Jan 8, 2025

OK — working now. Looks like it is a caching issue with Aries OCA Explorer. I’ll put in an issue and try to get it addressed. I don’t think it will happen in the wallet, but something we need to watch for.

@arbordeleau
Copy link
Contributor Author

Ohh ok! Thank you :)

@arbordeleau
Copy link
Contributor Author

IMG_9972
Seems like the OCA in the wallet is not appearing properly, is this possible?

@swcurran
Copy link
Contributor

swcurran commented Jan 8, 2025

Yup — looks like the same bug as in the OCA Explorer. This is the first time we have ever just changed an identifier for a bundle. My guess is that if you start a new wallet, it will work. We need to get a bug report into the wallet about the caching. I can do that, tagging you on it.

Could you try on a new phone to see if that works.

@swcurran
Copy link
Contributor

swcurran commented Jan 8, 2025

As I look at this — I think what you are showing is a credential from the old identifier, which has been removed. Did you just mean to add the new identifier, or did you mean to replace the old with the new. The change you made replaced the old with the new, so the old identifier no longer has an OCA Bundle associated with it. So what you are seeing is the expected result. We can have both identifiers used, so that the OCA Bundle works for credentials issued from the old Cred Def and the new one.

I don’t think this is a wallet bug.

@swcurran
Copy link
Contributor

swcurran commented Jan 8, 2025

You can differentiate between the old identifier and the new one by the “_” in the name.

@arbordeleau
Copy link
Contributor Author

Yeah i just understand now the issue.. sorry about that, just sent another PR!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants