Add public toggle to permissions modal #144
Conversation
norrisng-bc
requested review from
jujaga,
kyle1morel,
TimCsaky,
wilwong89 and
jatindersingh93
as code owners
Coverage Report (Application)
|
Coverage Report (Frontend)
|
| <h3 class="pb-1">Public</h3> | ||
| <ul> | ||
| <li>This option toggles the file to be publicly available and accessible to anyone</li> | ||
| <li>To instead set explicit permissions, add users and use the options below</li> |
There was a problem hiding this comment.
Maybe this?
To set explicit permission instead, add users and use the options below
Or this for a more active tone
Add users and use the options below to set explicit permissions instead
There was a problem hiding this comment.
I went with the wording in the screenshots in the original user research ticket (SHOWCASE-3331). Might want to check in with Tyler on that one.
| <div class="ml-4"> | ||
| <ObjectPublicToggle | ||
| v-if="object && getUserId" |
There was a problem hiding this comment.
Do we need the extra div levels or can this still work with the class applied to the ObjectPublicToggle component directly?
| <div class="mt-1 mb-2"> | ||
| <h3>User Permissions</h3> | ||
| </div> |
There was a problem hiding this comment.
Might be able to get away with just an h3 with class attribute and not require the div wrapper?
frontend/src/assets/primevue.scss
Outdated
| .p-dropdown.usersearch { | ||
| width: 100% !important | ||
| } |
There was a problem hiding this comment.
Unnecessary. You can use locally scoped css in SearchUsers.vue.
| @@ -208,6 +208,8 @@ export const useObjectStore = defineStore('object', () => { | |||
| try { | |||
| appStore.beginIndeterminateLoading(); | |||
| await objectService.togglePublic(objectId, isPublic); | |||
| const obj = findObjectById(objectId); | |||
| if (obj) obj.public = isPublic; | |||
There was a problem hiding this comment.
Are these two new lines doing anything?
was the intention to update the store. eg: if (obj) state.objects.value.find((x) => x.id === objectId).public = isPublic
There was a problem hiding this comment.
Yes we need to update the store here so the new value is reflected elsewhere. Would prefer to leave this using findObjectById() in the event we change up how we are looking up objects. Less things to track down and update.
There was a problem hiding this comment.
oh ok. i didnt know you could update the store like this
The updated dropdown hint is longer than before, so it doesn't fully display. The dropdown was therefore widened so that it shows the entire hint, filling the whitespace between it and the "Add" button.
Added "User Permissions" heading in the permissions modal, right above the "Add user" button. Also: tweak spacing for "Public" heading and corresponding toggle
In 60c2bad, the user search dropdown was widened to fill the width of the modal - this was achieved using !important in the Primevue stylesheet. This has been moved to a locally scoped style inside SearchUsers.vue instead, eliminating the need for !important.
norrisng-bc
force-pushed
the
public-toggle-inside-permissions
branch
from
643fc3d to
f692250
Compare
Description
This PR makes the following UX improvements to the object permissions modal, as originally identified in SHOWCASE-3331:
A bugfix on
/app/.gitignoreincorrectly ignoringpackage-lock.json(unrelated to the Jira ticket) has also been slipstreamed in.https://apps.nrs.gov.bc.ca/int/jira/browse/SHOWCASE-3366
Types of changes
Bug fix (non-breaking change which fixes an issue)
New feature (non-breaking change which adds functionality)
Checklist
Further comments
Screenshots
Object permissions modal:
Object permissions modal, after clicking "Add user":