Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SIMSBIOHUB-627: Get Telemetry endpoints #1405

Merged
merged 5 commits into from
Oct 22, 2024

Conversation

MacQSL
Copy link
Collaborator

@MacQSL MacQSL commented Oct 22, 2024

Links to Jira Tickets

  • {Include a link to all applicable Jira tickets}

Description of Changes

  • {List all relevant code changes. Include any changes to the business workflow that might not be obvious to the reviewers of this PR.}

Testing Notes

  • {List any relevant testing considerations, necessary pre-reqs, and areas of the app to focus on. Specifically, include anything that will help the reviewers of this PR verify the code is functioning as expected.}

@MacQSL MacQSL changed the base branch from dev to SIMSBIOHUB-627 October 22, 2024 17:20
Copy link

codecov bot commented Oct 22, 2024

Codecov Report

Attention: Patch coverage is 85.96491% with 8 lines in your changes missing coverage. Please review.

Please upload report for BASE (SIMSBIOHUB-627@4e915d6). Learn more about missing BASE report.

Files with missing lines Patch % Lines
.../survey/{surveyId}/deployments2/telemetry/index.ts 84.00% 4 Missing ⚠️
...Id}/deployments2/{deploymentId}/telemetry/index.ts 84.00% 4 Missing ⚠️
Additional details and impacted files
@@                Coverage Diff                @@
##             SIMSBIOHUB-627    #1405   +/-   ##
=================================================
  Coverage                  ?   47.00%           
=================================================
  Files                     ?      801           
  Lines                     ?    21487           
  Branches                  ?     3182           
=================================================
  Hits                      ?    10099           
  Misses                    ?    10804           
  Partials                  ?      584           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@NickPhura NickPhura left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

Super minor, and unrelated to these changes: I noticed the jsdoc for the get telemetry repo method says "Get Lotek telemetry data for list of deployment IDs."

Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
20.7% Duplication on New Code (required ≤ 3%)

See analysis details on SonarCloud

@MacQSL MacQSL merged commit 28b2c99 into SIMSBIOHUB-627 Oct 22, 2024
16 of 19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants