Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SIMSBIOHUB-627: Deprecate BCTW Device Service #1411

Merged
merged 2 commits into from
Oct 25, 2024

Conversation

MacQSL
Copy link
Collaborator

@MacQSL MacQSL commented Oct 24, 2024

Description of Changes

  • Deprecates BCTWDeviceService and related endpoints
  • Adds new section to CodesService to return telemetryDeviceMakes

Testing Notes

  • App should work as normal / compile
  • paths/codes should return all codes + new telemtry_device_makes

@MacQSL MacQSL changed the base branch from dev to SIMSBIOHUB-627 October 24, 2024 21:07
Copy link

Copy link

codecov bot commented Oct 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (SIMSBIOHUB-627@c797538). Learn more about missing BASE report.

Additional details and impacted files
@@                Coverage Diff                @@
##             SIMSBIOHUB-627    #1411   +/-   ##
=================================================
  Coverage                  ?   47.02%           
=================================================
  Files                     ?      803           
  Lines                     ?    21591           
  Branches                  ?     3180           
=================================================
  Hits                      ?    10154           
  Misses                    ?    10858           
  Partials                  ?      579           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@NickPhura NickPhura left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@NickPhura NickPhura merged commit 7bc4d06 into SIMSBIOHUB-627 Oct 25, 2024
19 checks passed
@NickPhura NickPhura deleted the SIMSBIOHUB-627-DEPRECATE-OLD-CODE branch October 25, 2024 00:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants