SIMSBIOHUB-665: Habitat Features Database Schema #1483
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Openshift URLs for the PR Deployment: |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev #1483 +/- ##
==========================================
- Coverage 47.74% 47.58% -0.16%
==========================================
Files 935 928 -7
Lines 25844 24188 -1656
Branches 3978 3609 -369
==========================================
- Hits 12340 11511 -829
+ Misses 12848 12043 -805
+ Partials 656 634 -22 ☔ View full report in Codecov by Sentry. |
- Fix/update environment table foreign keys/indexes. - Rename environment_unit database enum. - Update api/app references to database enums.
NickPhura
force-pushed
the
SIMSBIOHUB-665
branch
from
644a388 to
5c17785
Compare
MacQSL
reviewed
Feb 14, 2025
| * | ||
| * @description Data type for `alert_severity`. | ||
| */ | ||
| export const AlertSeverity = z.enum(['info', 'warning', 'error', 'success']); |
There was a problem hiding this comment.
question: Should we export the actual enum instead of the type? Would this be more useful?
Then at least downstream we would be able to reference it
export enum AlertSeverity {
info = 'info',
warning = 'warning',
...
}
export const AlertSeverityUnit = z.nativeEnum(AlertSeverity)
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Links to Jira Tickets
https://apps.nrs.gov.bc.ca/int/jira/browse/SIMSBIOHUB-665
Description of Changes
Initial Habitat Features database schema.
Bonus:
environment_qualitativeandenvironment_qualitative_optionnamecolumn inenvironment_qualitativeandenvironment_quantitativeenvironment_unittoquantitative_unitquantitative_unitalert_severityTesting Notes
Database migrations run as expected.
Has appropriate constraints, indexes, etc.
TODO
Table
survey_habitat_featureIf we do add
survey_sample_period_idandsurvey_observation_id, should we restrict it to only one of them, since having both would be redundant?