Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initial Survey Habitat Feature API Models, Services, Repos. #1512

Open
wants to merge 1 commit into
base: habitat-features-branch
Choose a base branch
from

Conversation

NickPhura
Copy link
Collaborator

@NickPhura NickPhura commented Feb 27, 2025

Links to Jira Tickets

https://apps.nrs.gov.bc.ca/int/jira/browse/SIMSBIOHUB-673

Description of Changes

  • Add habitat_feature_type codes to codes endpoint/service/repo.
  • Add GET endpoint for survey habitat features. Add related service/repo functions.
  • Add database-models for all new habitat feature related tables.
  • Update seed to include survey habitat feature records.

Testing Notes

Should be able to call GET .../survey/{surveyId}/habitat-features

Added a postman endpoint for the above request.

- Add GET endpoint for survey habitat features. Add related service/repo functions.
- Add database-models for all new habitat feature related tables.
- Update seed to include survey habitat feature records.
@NickPhura NickPhura requested a review from MacQSL February 27, 2025 22:52
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
29.1% Duplication on New Code (required ≤ 3%)

See analysis details on SonarQube Cloud

Copy link

codecov bot commented Feb 27, 2025

Codecov Report

Attention: Patch coverage is 1.78571% with 165 lines in your changes missing coverage. Please review.

Project coverage is 47.11%. Comparing base (6b3675e) to head (ba2fd4c).

Files with missing lines Patch % Lines
...c/repositories/habitat-feature-repository/utils.ts 0.00% 38 Missing ⚠️
...t-feature-repository/habitat-feature-repository.ts 0.00% 36 Missing ⚠️
...re-repository/survey-habitat-feature-repository.ts 0.00% 26 Missing ⚠️
...ectId}/survey/{surveyId}/habitat-features/index.ts 0.00% 20 Missing ⚠️
...feature-services/survey-habitat-feature-service.ts 0.00% 10 Missing ⚠️
api/src/openapi/schemas/survey-habitat-feature.ts 0.00% 5 Missing ⚠️
...abitat-feature-services/habitat-feature-service.ts 0.00% 5 Missing ⚠️
...repository/habitat-feature-repository.interface.ts 0.00% 3 Missing ⚠️
api/src/database-models/habitat-feature-type.ts 0.00% 2 Missing ⚠️
...e-models/habitat_feature_qualitative_definition.ts 0.00% 2 Missing ⚠️
... and 9 more
Additional details and impacted files
@@                     Coverage Diff                     @@
##           habitat-features-branch    #1512      +/-   ##
===========================================================
- Coverage                    47.57%   47.11%   -0.47%     
===========================================================
  Files                          926      961      +35     
  Lines                        24182    24379     +197     
  Branches                      3609     3642      +33     
===========================================================
- Hits                         11505    11486      -19     
- Misses                       12043    12256     +213     
- Partials                       634      637       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant