Skip to content

Commit

Permalink
22446 Allow AR corrections (depending on FF) (#687)
Browse files Browse the repository at this point in the history
- app version = 7.3.18
- allowed Annual Report corrections for specified legal types only (per FF)
- added new FF with default value

Co-authored-by: Severin Beauvais <[email protected]>
  • Loading branch information
severinbeauvais and Severin Beauvais authored Jul 25, 2024
1 parent 2379af6 commit c0c023b
Show file tree
Hide file tree
Showing 4 changed files with 10 additions and 4 deletions.
4 changes: 2 additions & 2 deletions package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "business-filings-ui",
"version": "7.3.17",
"version": "7.3.18",
"private": true,
"appName": "Filings UI",
"sbcName": "SBC Common Components",
Expand Down
7 changes: 6 additions & 1 deletion src/components/Dashboard/FilingHistoryList/HeaderActions.vue
Original file line number Diff line number Diff line change
Expand Up @@ -84,6 +84,7 @@ import { ApiFilingIF } from '@/interfaces'
import { AllowableActionsMixin } from '@/mixins'
import { EnumUtilities } from '@/services'
import { useBusinessStore, useFilingHistoryListStore, useRootStore } from '@/stores'
import { GetFeatureFlag } from '@/utils'
@Component({})
export default class HeaderActions extends Mixins(AllowableActionsMixin) {
Expand All @@ -92,6 +93,7 @@ export default class HeaderActions extends Mixins(AllowableActionsMixin) {
@Prop({ required: true }) readonly filing!: ApiFilingIF
@Prop({ required: true }) readonly index!: number
// @Getter(useBusinessStore) getLegalType!: CorpTypeCd
@Getter(useBusinessStore) isBaseCompany!: boolean
@Getter(useRootStore) isBootstrapFiling!: boolean
@Getter(useBusinessStore) isDisableNonBenCorps!: boolean
Expand Down Expand Up @@ -142,7 +144,10 @@ export default class HeaderActions extends Mixins(AllowableActionsMixin) {
if (!this.isBaseCompany) return true
return false
case EnumUtilities.isTypeAmalgamationOut(this.filing): return true // not supported
case EnumUtilities.isTypeAnnualReport(this.filing): return true // not supported
case EnumUtilities.isTypeAnnualReport(this.filing):
// enable AR corrections for specified legal types only
if (GetFeatureFlag('supported-ar-correction-entities').includes(this.getLegalType)) return false
return true
case EnumUtilities.isTypeChangeOfAddress(this.filing): return false
case EnumUtilities.isTypeChangeOfCompanyInfo(this.filing): return true // not supported
case EnumUtilities.isTypeChangeOfDirectors(this.filing): return false
Expand Down
1 change: 1 addition & 0 deletions src/utils/feature-flags.ts
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,7 @@ const defaultFlagSet: LDFlagSet = {
'supported-agm-location-chg-entities': [],
'supported-amalgamation-entities': [],
'supported-amalgamation-out-entities': [],
'supported-ar-correction-entities': [],
'supported-business-summary-entities': [],
'supported-consent-amalgamation-out-entities': [],
'supported-consent-continuation-out-entities': [],
Expand Down

0 comments on commit c0c023b

Please sign in to comment.