Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

6168 Todo List refactor WIP (DO NOT DELETE) #390

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

severinbeauvais
Copy link
Collaborator

@severinbeauvais severinbeauvais commented Sep 21, 2022

Issue #: bcgov/entity#6168

Description of changes:

This PR contains some Todo List cleanup WIP code changes. Do not delete this PR or branch!

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the business-filings-ui license (Apache 2.0).

@severinbeauvais severinbeauvais self-assigned this Sep 21, 2022
@severinbeauvais severinbeauvais changed the title 6168 Todo List refactor WIP (DO NOT DELETE) 6168 Todo List refactor WIP (DO NOT DELETE BRANCH) Sep 21, 2022
@severinbeauvais severinbeauvais changed the title 6168 Todo List refactor WIP (DO NOT DELETE BRANCH) 6168 Todo List refactor WIP (DO NOT DELETE) Sep 21, 2022
@codecov
Copy link

codecov bot commented Sep 21, 2022

Codecov Report

Merging #390 (556ec42) into main (46389cd) will increase coverage by 3.20%.
The diff coverage is 87.50%.

@@            Coverage Diff             @@
##             main     #390      +/-   ##
==========================================
+ Coverage   82.88%   86.09%   +3.20%     
==========================================
  Files         109      110       +1     
  Lines        2104     2114      +10     
  Branches      659      671      +12     
==========================================
+ Hits         1744     1820      +76     
+ Misses        360      294      -66     
Impacted Files Coverage Δ
src/App.vue 85.07% <ø> (ø)
src/components/Dashboard/FilingHistoryList.vue 83.56% <ø> (ø)
src/components/Dashboard/StaffNotation.vue 100.00% <ø> (ø)
...nents/DigitalCredentials/DigitalWalletDownload.vue 100.00% <ø> (ø)
src/components/EntityInfo.vue 100.00% <ø> (ø)
src/components/common/Certify.vue 100.00% <ø> (ø)
src/components/common/DetailComment.vue 100.00% <ø> (ø)
src/components/common/Directors.vue 72.34% <ø> (ø)
src/components/common/NameRequestInfo.vue 100.00% <ø> (ø)
src/components/common/OfficeAddresses.vue 69.23% <ø> (ø)
... and 32 more

- initial Todo List 3 test suite WIP
@sonarcloud
Copy link

sonarcloud bot commented Sep 21, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

No Coverage information No Coverage information
0.0% 0.0% Duplication

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant