Merge pull request #98 from ritvick/feature/12775

Feature 12775 - Add details to dissolution shema
bcgov · Jun 28, 2022 · a9dfb3d · a9dfb3d
2 parents 0d01d82 + f316cbe
commit a9dfb3d
Show file tree

Hide file tree

Showing 3 changed files with 21 additions and 1 deletion.
diff --git a/src/registry_schemas/schemas/dissolution.json b/src/registry_schemas/schemas/dissolution.json
@@ -30,6 +30,11 @@
                         "courtOrderedLiquidation"
                     ]
                 },
+                "details": {
+                    "type": "string",
+                    "minLength": 0,
+                    "maxLength": 2000
+                },
                 "dissolutionStatementType": {
                     "type": "string"
                 },

diff --git a/src/registry_schemas/version.py b/src/registry_schemas/version.py
@@ -22,4 +22,4 @@
 Development release segment: .devN
 """
 
-__version__ = '2.15.24'  # pylint: disable=invalid-name
+__version__ = '2.15.25'  # pylint: disable=invalid-name
diff --git a/tests/unit/test_dissolution.py b/tests/unit/test_dissolution.py
@@ -83,6 +83,21 @@ def test_dissolution_court_order():
 
     assert is_valid
 
+def test_administrative_dissolution_schema():
+    """Assert that the JSONSchema validator is working."""
+    legal_filing = {'dissolution': copy.deepcopy(DISSOLUTION)}
+    legal_filing['dissolution']['dissolutionType'] = 'administrative'
+    legal_filing['dissolution']['details'] = 'Some Details'
+
+    is_valid, errors = validate(legal_filing, 'dissolution')
+
+    if errors:
+        for err in errors:
+            print(err.message)
+    print(errors)
+
+    assert is_valid
+
 
 @pytest.mark.parametrize('invalid_court_order', [
     *[{'orderDate': '2021-01-30T09:56:01+08:00',