fix: Remove return types from Save

* This was causing the CreateAllocationAgreementSchema validation to run despite the types being defined as a union. AFAIK Flask does not like union types on views.
bcgov · Feb 21, 2025 · 75d13d2 · 75d13d2
1 parent a92d4bd
commit 75d13d2
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 5 deletions.
diff --git a/backend/lcfs/web/api/allocation_agreement/views.py b/backend/lcfs/web/api/allocation_agreement/views.py
@@ -134,9 +134,6 @@ async def get_allocation_agreements_paginated(
 
 @router.post(
     "/save",
-    response_model=Union[
-        AllocationAgreementSchema, DeleteAllocationAgreementResponseSchema
-    ],
     status_code=status.HTTP_200_OK,
 )
 @view_handler([RoleEnum.COMPLIANCE_REPORTING, RoleEnum.SIGNING_AUTHORITY])

diff --git a/frontend/src/components/BCDataGrid/BCGridEditor.jsx b/frontend/src/components/BCDataGrid/BCGridEditor.jsx
@@ -200,12 +200,12 @@ export const BCGridEditor = ({
   const onCellFocused = (params) => {
     if (params.column) {
       // Ensure the focused column is always visible
-      this.gridApi.ensureColumnVisible(params.column)
+      params.gridApi.ensureColumnVisible(params.column)
 
       // Scroll to make focused cell align to left
       const leftPos = params.column.getLeftPosition()
       if (leftPos !== null) {
-        this.gridApi.horizontalScrollTo(leftPos)
+        params.gridApi.horizontalScrollTo(leftPos)
       }
     }
   }