Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Import Fixes and add feature flag #2064

Merged
merged 2 commits into from
Feb 25, 2025
Merged

fix: Import Fixes and add feature flag #2064

merged 2 commits into from
Feb 25, 2025

Conversation

dhaselhan
Copy link
Collaborator

  • Empty row should not be an error
  • Convert non int fields to str
  • Add feature flag for import export

@dhaselhan
fix: Add Import Fixes and feature flag
30825e0 
* Empty row should not be an error
* Convert non int fields to str
* Add feature flag for import export
@dhaselhan dhaselhan requested a review from AlexZorkin February 21, 2025 01:16
@dhaselhan dhaselhan changed the title fix: Add Import Fixes and feature flag fix: Import Fixes and add feature flag Feb 21, 2025
@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 21, 2025 •
edited
Loading

Frontend Test Results

  1 files  ±0  130 suites  ±0   49s ⏱️ -1s
458 tests ±0  438 ✅ ±0  20 💤 ±0  0 ❌ ±0 
460 runs  ±0  440 ✅ ±0  20 💤 ±0  0 ❌ ±0 

Results for commit 480c017. ± Comparison against base commit 3fd2a6b.

♻️ This comment has been updated with latest results.

@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 21, 2025 •
edited
Loading

Backend Test Results

590 tests  ±0   590 ✅ ±0   2m 42s ⏱️ -5s
  1 suites ±0     0 💤 ±0 
  1 files   ±0     0 ❌ ±0 

Results for commit 480c017. ± Comparison against base commit 3fd2a6b.

♻️ This comment has been updated with latest results.

AlexZorkin
AlexZorkin approved these changes Feb 24, 2025
View reviewed changes
Copy link
Collaborator

@AlexZorkin AlexZorkin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@dhaselhan dhaselhan merged commit 92c6c92 into release-1.0.0 Feb 25, 2025
11 checks passed
@dhaselhan dhaselhan deleted the fix/daniel-ff-import-1927 branch February 25, 2025 22:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AlexZorkin AlexZorkin AlexZorkin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dhaselhan @AlexZorkin