Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Improve email formatting and header display - 1930 #2065

Merged
merged 2 commits into from
Feb 21, 2025

Conversation

hamed-valiollahi
Copy link
Collaborator

Changes in this PR:

  • Ensures full-width layout instead of a fixed width for better responsiveness
  • Fixes email header display where the logo and title were not showing correctly in different email clients
  • Adds action to transaction type to match the in-app display

Closes #1930

Copy link

github-actions bot commented Feb 21, 2025

Frontend Test Results

  1 files  ±0  130 suites  ±0   48s ⏱️ -2s
448 tests ±0  428 ✅ ±0  20 💤 ±0  0 ❌ ±0 
450 runs  ±0  430 ✅ ±0  20 💤 ±0  0 ❌ ±0 

Results for commit fee6b6e. ± Comparison against base commit 5d41c28.

♻️ This comment has been updated with latest results.

Copy link

github-actions bot commented Feb 21, 2025

Backend Test Results

590 tests  ±0   590 ✅ ±0   2m 47s ⏱️ +3s
  1 suites ±0     0 💤 ±0 
  1 files   ±0     0 ❌ ±0 

Results for commit fee6b6e. ± Comparison against base commit 5d41c28.

♻️ This comment has been updated with latest results.

Copy link
Collaborator

@dhaselhan dhaselhan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@hamed-valiollahi hamed-valiollahi merged commit 55956b7 into release-1.0.0 Feb 21, 2025
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

LCFS - Align Email Notification Text with In-App Notifications
2 participants