Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Hide internal statuses and fix submitted status filtering for BCeID users - 2050 #2075

Merged

Conversation

hamed-valiollahi
Copy link
Collaborator

@hamed-valiollahi hamed-valiollahi commented Feb 21, 2025

This PR includes the following improvements and fixes:

  • Internal statuses are now restricted to IDIR users
  • Fixed an issue where filtering for submitted statuses caused a 500 error.
  • Formatted Python code for better readability and consistency

Closes #2050

Copy link

github-actions bot commented Feb 21, 2025

Frontend Test Results

  1 files  ±0  130 suites  ±0   48s ⏱️ -1s
458 tests ±0  438 ✅ ±0  20 💤 ±0  0 ❌ ±0 
460 runs  ±0  440 ✅ ±0  20 💤 ±0  0 ❌ ±0 

Results for commit d67460d. ± Comparison against base commit 92c6c92.

♻️ This comment has been updated with latest results.

Copy link

github-actions bot commented Feb 21, 2025

Backend Test Results

590 tests  ±0   590 ✅ ±0   2m 44s ⏱️ -4s
  1 suites ±0     0 💤 ±0 
  1 files   ±0     0 ❌ ±0 

Results for commit d67460d. ± Comparison against base commit 92c6c92.

♻️ This comment has been updated with latest results.

Copy link
Collaborator

@prv-proton prv-proton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍

@hamed-valiollahi hamed-valiollahi merged commit 9bf2fa0 into release-1.0.0 Feb 25, 2025
11 checks passed
@dhaselhan dhaselhan deleted the fix/hamed-hide-statuses-filter-bceid-2050 branch February 25, 2025 23:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

LCFS - BUG - Internal statuses are incorrectly visible on the BCeID
3 participants