[MDS-5644]updating test enviornment banner and adding core home page link #2878
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
taraepp
reviewed
Jan 9, 2024
| @@ -63,6 +63,10 @@ const ExternalLinksSection = () => { | |||
| title: "First Nation Consultation System", | |||
| url: "https://apps.nrs.gov.bc.ca/int/fncs", | |||
| }, | |||
| { | |||
| title: "Regional Mines Public Engagement Tool Portal", | |||
| url: "http://www.gov.bc.ca/minesengagement", | |||
There was a problem hiding this comment.
Code scanning tools do favour https over http- when I copied this link into my browser it redirected me to an HTTPS url, and even just adding in the "s" to this link worked. Would recommend probably adding the "s"
There was a problem hiding this comment.
Good eye, this has been changed now.
asinn134
requested review from
taraepp,
simensma-fresh,
henryoforeh-dev,
matbusby-fw and
isuru-aot
henryoforeh-dev
approved these changes
Jan 10, 2024
matbusby-fw
approved these changes
Jan 10, 2024
asinn134
deleted the
mds-5644-and-5665-test-banner-and-engagement-tool-link
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Objective
MDS-5644
MDS-5665