Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[MDS-5720] Order file upload parts ascending, fix errors when uploading multiple files #2881

Merged
merged 6 commits into from
Jan 12, 2024
Merged

[MDS-5720] Order file upload parts ascending, fix errors when uploading multiple files #2881

merged 6 commits into from
Jan 12, 2024

Conversation

simensma-fresh
Copy link
Collaborator

Objective

MDS-5720

  • Fixed a 400 error that happens when completing the file upload and the parts IDs passed along are not in ascending order.
  • Fixed a 500 error that sometimes happen where a file upload would try to upload a chunk to a url that has already been used. Cause of this was that the state kept with the upload results (for resuming an upload if it fails) was not scoped by file ID.
  • Some tweaks to get the file replacement working with these changes

simensma-fresh
simensma-fresh commented Jan 12, 2024
View reviewed changes
...ices/minespace-web/src/components/Forms/projects/projectSummary/ProjectSummaryFileUpload.tsx
document_manager_guid: mineDocumentGuid,
});
};

const onError = (filename: string, e) => {
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No changes was actually made to the method, just moved it out of the component

@simensma-fresh simensma-fresh added 👍 Ready for review Pull request has been double checked by the author and is ready for comments and feedback. 💻 Frontend This pull request includes frontend changes. labels Jan 12, 2024
matbusby-fw
matbusby-fw previously approved these changes Jan 12, 2024
View reviewed changes
Copy link
Collaborator

@matbusby-fw matbusby-fw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

@simensma-fresh simensma-fresh merged commit 2eb0b6c into develop Jan 12, 2024
10 checks passed
@simensma-fresh simensma-fresh deleted the MDS-5720_File-upload-fixes branch January 12, 2024 19:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@henryoforeh-dev henryoforeh-dev henryoforeh-dev approved these changes

@matbusby-fw matbusby-fw matbusby-fw approved these changes

@taraepp taraepp Awaiting requested review from taraepp

@isuru-aot isuru-aot Awaiting requested review from isuru-aot

@asinn134 asinn134 Awaiting requested review from asinn134

Assignees
No one assigned
Labels
💻 Frontend This pull request includes frontend changes. 👍 Ready for review Pull request has been double checked by the author and is ready for comments and feedback.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@simensma-fresh @henryoforeh-dev @matbusby-fw