Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MDS-5678] ESUP map pin fix #2896

Merged
merged 1 commit into from
Jan 18, 2024
Merged

[MDS-5678] ESUP map pin fix #2896

merged 1 commit into from
Jan 18, 2024

Conversation

matbusby-fw
Copy link
Collaborator

Objective

  • On creation of the initial map pin, assigned it to the pinRef that is being updated in subsequent calls.

MDS-5678

image

@@ -57,6 +59,7 @@ const ExplosivesPermitMap: FC<ExplosivesPermitMapProps> = ({ pin = [] }) => {
iconSize: [60, 60],
});
pin = L.marker(pin, { icon: customIcon });
pinRef.current = pin;
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The rest is just formatting. This is the fix.

@matbusby-fw matbusby-fw added 💻 Frontend This pull request includes frontend changes. 💊 Fix Fixes something that isn't working :) 👍 Ready for review Pull request has been double checked by the author and is ready for comments and feedback. labels Jan 18, 2024
Copy link
Contributor

@henryoforeh-dev henryoforeh-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@@ -1,4 +1,4 @@
import React, { Component, FC, useEffect, useRef, useState } from "react";
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, get rid of those unused imports!

@matbusby-fw matbusby-fw merged commit 300223d into develop Jan 18, 2024
10 checks passed
@matbusby-fw matbusby-fw deleted the mds-5678-map-pin-updates branch January 18, 2024 21:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
💊 Fix Fixes something that isn't working :) 💻 Frontend This pull request includes frontend changes. 👍 Ready for review Pull request has been double checked by the author and is ready for comments and feedback.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants