Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MDS-5737] Fixed incosistent path on new file uploads #2898

Merged
merged 1 commit into from
Jan 18, 2024

Conversation

simensma-fresh
Copy link
Collaborator

Objective

MDS-5737

The new file upload logic didn't append the S3_PREFIX when saving the object_store_path, just when copying the file there, making the saved path referencing a file that doesn't exist.

image

A couple of other changes:

  • Leftover fix for Viewing documents in document viewer when using the action menu in Minespace
  • Updated filesystem_manager env variable to match what's expected. Syncfusion should now work out of the box when running the project locally as long as the filesystem_provider pod is running

matbusby-fw
matbusby-fw previously approved these changes Jan 18, 2024
@simensma-fresh simensma-fresh force-pushed the MDS-5737_PDF-document-viewer branch from 20cc432 to 34e046b Compare January 18, 2024 21:24
@simensma-fresh simensma-fresh merged commit 25cedc7 into develop Jan 18, 2024
14 of 15 checks passed
@simensma-fresh simensma-fresh deleted the MDS-5737_PDF-document-viewer branch January 18, 2024 21:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants