New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FIX] Ask to confirm delete permit conditions before doing it #3427

Merged

taraepp merged 2 commits into develop from fix-confirm-delete-conditions

Feb 20, 2025

Collaborator

taraepp commented Feb 20, 2025

Objective

it's surprising when it just deletes the conditions
so confirm first
also I was getting one type error in one of the compiles there so I made it go away

Why are you making this change? Provide a short explanation and/or screenshots

taraepp added 2 commits

February 20, 2025 15:00


          ask to confirm delete conditions before doing it

ef35328


          get rid of a type error

cc3ab82

sonarqubecloud bot commented Feb 20, 2025

Quality Gate passed for 'bcgov-sonarcloud_mds_minespace-web'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

sonarqubecloud bot commented Feb 20, 2025

Quality Gate passed for 'bcgov-sonarcloud_mds_common'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
16.7% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

sonarqubecloud bot commented Feb 20, 2025

Quality Gate passed for 'bcgov-sonarcloud_mds_core-web'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
50.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

matbusby-fw approved these changes

View reviewed changes

asinn134 approved these changes

View reviewed changes

taraepp merged commit 09b28b8 into develop

17 checks passed

taraepp deleted the fix-confirm-delete-conditions branch

February 20, 2025 18:01

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet