Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[MDS-6396] Allow all Core users to view permit conditions page #3438

Merged
merged 1 commit into from
Feb 27, 2025
Merged

[MDS-6396] Allow all Core users to view permit conditions page #3438

merged 1 commit into from
Feb 27, 2025
+179 −21

Conversation

taraepp
Copy link
Collaborator

@taraepp taraepp commented Feb 27, 2025

Objective

  • technically they could view the page before, they just didn't have a link to it from the table
  • was clicking around and noticed the document viewing button did a toggle but didn't toggle the button text so I changed that

MDS-6396

Why are you making this change? Provide a short explanation and/or screenshots

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Failed Quality Gate failed for 'bcgov-sonarcloud_mds_core-web'

Failed conditions
77.9% Coverage on New Code (required ≥ 80%)

See analysis details on SonarQube Cloud

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed for 'bcgov-sonarcloud_mds_core-api'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@taraepp taraepp added the 👍 Ready for review Pull request has been double checked by the author and is ready for comments and feedback. label Feb 27, 2025
@taraepp taraepp merged commit e513aa8 into develop Feb 27, 2025
15 of 16 checks passed
@taraepp taraepp deleted the mds-6396-permit-conditions-view-users branch February 27, 2025 19:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matbusby-fw matbusby-fw matbusby-fw approved these changes

@asinn134 asinn134 asinn134 approved these changes

@simensma-fresh simensma-fresh Awaiting requested review from simensma-fresh

@sggerard sggerard Awaiting requested review from sggerard

Assignees
No one assigned
Labels
👍 Ready for review Pull request has been double checked by the author and is ready for comments and feedback.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@taraepp @matbusby-fw @asinn134