Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DESENG-492 Enhance analytics API #2397

Merged
merged 3 commits into from
Feb 28, 2024
Merged

Conversation

VineetBala-AOT
Copy link
Collaborator

Issue #: https://apps.itsm.gov.bc.ca/jira/browse/DESENG-492

Description of changes:
- Refactor analytics-api config to harmonize its structure and conventions with met-api.
- Ensure the sample.env file maintains consistent formatting.
- Adjusted column size in the comment table of the met-api to resolve an error encountered during user submissions.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the met-public license (Apache 2.0).

Copy link

sonarcloud bot commented Feb 27, 2024

Quality Gate Passed Quality Gate passed

Issues
1 New issue

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@codecov-commenter
Copy link

codecov-commenter commented Feb 27, 2024

Codecov Report

Attention: Patch coverage is 72.72727% with 15 lines in your changes are missing coverage. Please review.

Project coverage is 84.95%. Comparing base (05be8f3) to head (929b512).

Additional details and impacted files
@@             Coverage Diff             @@
##             main    #2397       +/-   ##
===========================================
+ Coverage   74.15%   84.95%   +10.80%     
===========================================
  Files         529      235      -294     
  Lines       18045     9242     -8803     
  Branches     1344        0     -1344     
===========================================
- Hits        13381     7852     -5529     
+ Misses       4455     1390     -3065     
+ Partials      209        0      -209     
Flag Coverage Δ
analyticsapi 77.34% <72.72%> (?)
metapi 85.65% <ø> (ø)
metweb ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
analytics-api/src/analytics_api/config.py 95.12% <100.00%> (ø)
...pi/src/analytics_api/models/request_type_option.py 44.44% <ø> (ø)
analytics-api/src/analytics_api/auth.py 67.74% <75.00%> (ø)
...lytics-api/src/analytics_api/utils/user_context.py 55.00% <50.00%> (ø)
analytics-api/src/analytics_api/utils/util.py 78.37% <37.50%> (ø)
analytics-api/src/analytics_api/__init__.py 75.55% <11.11%> (ø)

... and 364 files with indirect coverage changes

@VineetBala-AOT VineetBala-AOT marked this pull request as ready for review February 27, 2024 19:26
@VineetBala-AOT VineetBala-AOT merged commit 28fd55e into main Feb 28, 2024
15 checks passed
@VineetBala-AOT VineetBala-AOT deleted the feature/deseng-492-final branch March 3, 2024 23:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants