Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Healthcheck, nginx fix, added tests for django #102

Merged
merged 15 commits into from
Mar 18, 2024

Conversation

tobiasmllr
Copy link
Collaborator

@tobiasmllr tobiasmllr commented Mar 17, 2024

Description

Please provide a summary of the change and the issue fixed. Please include relevant context. List dependency changes.

Fixes # (issue)

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Test A
  • Test B

Checklist

  • I have read the CONTRIBUTING doc
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have already been accepted and merged

Further comments


Thanks for the PR!

Deployments, as required, will be available below:

Please create PRs in draft mode. Mark as ready to enable:

After merge, new images are deployed in:

@tobiasmllr tobiasmllr linked an issue Mar 18, 2024 that may be closed by this pull request
1 task
@tobiasmllr tobiasmllr changed the title feat: Healthcheck and nginx fix feat: Healthcheck, nginx fix, added tests for django Mar 18, 2024
@DerekRoberts
Copy link
Member

@tobiasmllr Thanks for reporting deploy blocks. There was a cleanup bug, with the change merged into main and updated into this PR.

@tobiasmllr tobiasmllr merged commit a8ffeb1 into main Mar 18, 2024
13 checks passed
@tobiasmllr tobiasmllr deleted the healthcheck-and-nginx-fix branch March 18, 2024 19:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix code scanning alert - No HEALTHCHECK defined
2 participants