Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Acronym display bug #1345

Closed
craigyu opened this issue Jul 5, 2024 · 3 comments · Fixed by #1425
Closed

Acronym display bug #1345

craigyu opened this issue Jul 5, 2024 · 3 comments · Fixed by #1425
Assignees

Comments

@craigyu
Copy link
Collaborator

craigyu commented Jul 5, 2024

the agency acronym input display different text when in different mode, this bug might appears in other screens as well.

Image

@mgaseta
Copy link
Collaborator

mgaseta commented Jul 9, 2024

Few questions for @SLDonnelly:

  • When in read mode, should we display only the acronym or the whole name (client number - name - acronym)?
  • Which is the correct pattern for the agency field label? Should it say only: "XXX agency", "XXX agency acronym"
  • For the location code field, should the label of the field display "agency location code" or "applicant agency number"?
  • The email field label, should it be "Email address" or "Applicant email address"?

@SLDonnelly
Copy link
Collaborator

@mgaseta

  • When in read mode, should we display only the acronym or the whole name (client number - name - acronym)?
    

This is a good question, I think it's nice having all the information visible. @mmarsoleta @kevinginley do you agree?

  • Which is the correct pattern for the agency field label? Should it say only: "XXX agency", "XXX agency acronym"
    
    "XXX agency acronym"
  • For the location code field, should the label of the field display "agency location code" or "applicant agency number"?
    "agency location code"
    
  • The email field label, should it be "Email address" or "Applicant email address"?
    

I think that just "email address" is fine

@kevinginley
Copy link
Collaborator

Yes I agree with having (client number - name - acronym) all be visible in read mode

@mgaseta mgaseta linked a pull request Jul 19, 2024 that will close this issue
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment