Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: ui issues and improvements pt. 1 #1425

Merged
merged 12 commits into from
Jul 30, 2024
Merged

Conversation

mgaseta
Copy link
Collaborator

@mgaseta mgaseta commented Jul 19, 2024

Description

Closes #1345
Closes #908
Closes points 1, 3 and 5 from: #1386
Closes this and this from #1388
Also, fixes the wrong subtitles when reviewing the orchard step.

Changelog

New

  • New scroll to the top component.

Changed

  • Texts and styles

Removed

  • Nothing :)

How was this tested?

  • 🧠 Not needed
  • 👀 Eyeball
  • 🤖 Added tests

What gif/image best describes this PR or how it makes you feel?


Thanks for the PR!

Deployments, as required, will be available below:

Please create PRs in draft mode. Mark as ready to enable:

After merge, new images are deployed in:


Thanks for the PR!

Deployments, as required, will be available below:

Please create PRs in draft mode. Mark as ready to enable:

After merge, new images are deployed in:

@mgaseta mgaseta self-assigned this Jul 19, 2024
@mgaseta mgaseta linked an issue Jul 19, 2024 that may be closed by this pull request
Copy link
Contributor

@RMCampos RMCampos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job 🥇

@mgaseta mgaseta enabled auto-merge (squash) July 30, 2024 13:58
@mgaseta mgaseta disabled auto-merge July 30, 2024 13:58
@RMCampos RMCampos merged commit a4997e1 into main Jul 30, 2024
26 of 28 checks passed
@RMCampos RMCampos deleted the fix/1345-acronym-display-bug branch July 30, 2024 13:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Seedlot registration test: UI/UX Issues Acronym display bug Typo on step 6 of seedlot registration
3 participants