Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: generic function for revision count #1367

Merged
merged 7 commits into from
Jul 9, 2024

Conversation

RMCampos
Copy link
Contributor

@RMCampos RMCampos commented Jul 9, 2024

Description

Closes #1255

Changelog

New

  • Revision count dto to patch applicant info

Changed

  • SeedlotService adding validation to make sure user sent the latest version.

Removed

  • None.

How was this tested?

  • 🧠 Not needed
  • 👀 Eyeball
  • 🤖 Added tests

What gif/image best describes this PR or how it makes you feel?


Thanks for the PR!

Deployments, as required, will be available below:

Please create PRs in draft mode. Mark as ready to enable:

After merge, new images are deployed in:

Copy link
Collaborator

@mgaseta mgaseta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@RMCampos RMCampos enabled auto-merge (squash) July 9, 2024 21:35
@RMCampos RMCampos merged commit 2b424af into main Jul 9, 2024
27 of 28 checks passed
@RMCampos RMCampos deleted the feat/1255-generic-function-for-revision_count branch July 9, 2024 21:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🏆 Create generic function to save entities given entities IDs + revision_count
2 participants