Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: sonarcloud reliability warnings #1379

Merged
merged 3 commits into from
Jul 10, 2024
Merged

chore: sonarcloud reliability warnings #1379

merged 3 commits into from
Jul 10, 2024

Conversation

DerekRoberts
Copy link
Member

@DerekRoberts DerekRoberts commented Jul 10, 2024 •
edited by github-actions bot
Loading

Description

SonarCloud is kicking up the following reliability warnings:

Changelog

Changed

  • Slight adjustments as recommended

How was this tested?

  • 🧠 Not needed
  • 👀 Eyeball
  • 🤖 Added tests

What gif/image best describes this PR or how it makes you feel?

Thanks for the PR!

Deployments, as required, will be available below:

Please create PRs in draft mode. Mark as ready to enable:

After merge, new images are deployed in:

@DerekRoberts DerekRoberts self-assigned this Jul 10, 2024
@DerekRoberts DerekRoberts marked this pull request as ready for review July 10, 2024 19:17
@DerekRoberts DerekRoberts added devops devops related task tech-debt labels Jul 10, 2024
RMCampos
RMCampos approved these changes Jul 10, 2024
View reviewed changes
Copy link
Contributor

@RMCampos RMCampos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@DerekRoberts DerekRoberts enabled auto-merge (squash) July 10, 2024 19:32
@DerekRoberts DerekRoberts merged commit a796f51 into main Jul 10, 2024
28 checks passed
@DerekRoberts DerekRoberts deleted the chore/sonar branch July 10, 2024 19:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RMCampos RMCampos RMCampos approved these changes

@craigyu craigyu Awaiting requested review from craigyu

@mgaseta mgaseta Awaiting requested review from mgaseta mgaseta is a code owner

@SLDonnelly SLDonnelly Awaiting requested review from SLDonnelly SLDonnelly is a code owner

Assignees

@DerekRoberts DerekRoberts

Labels
devops devops related task tech-debt
Projects
DevOps (NR)
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@DerekRoberts @RMCampos