Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: orchard requests taking too long #1395

Merged
merged 3 commits into from
Jul 16, 2024
Merged

fix: orchard requests taking too long #1395

merged 3 commits into from
Jul 16, 2024

Conversation

RMCampos
Copy link
Contributor

@RMCampos RMCampos commented Jul 16, 2024 •
edited by github-actions bot
Loading

Description

Closes #1393

Changelog

Changed

  • SPAR Bec Zones Service to get all codes at once.

How was this tested?

  • 🧠 Not needed
  • 👀 Eyeball
  • 🤖 Added tests

What gif/image best describes this PR or how it makes you feel?

Thanks for the PR!

Deployments, as required, will be available below:

Please create PRs in draft mode. Mark as ready to enable:

After merge, new images are deployed in:

@RMCampos RMCampos self-assigned this Jul 16, 2024
@RMCampos RMCampos linked an issue Jul 16, 2024 that may be closed by this pull request
Orchard requests taking too long #1393
Closed
@RMCampos
Copy link
Contributor Author

API working great!
image

And there's now only ONE query in the database to get all descriptions:

2024-07-16T17:31:51.932Z  INFO 49 --- [spar-oracle-api] [nio-8090-exec-4] c.b.g.o.service.SparBecCatalogueService  : 617925f3-0975-4f7d-a8f3-0133e68363c4 Begin service request to find the description of a given BEC zone code
2024-07-16T17:31:51.943Z  INFO 49 --- [spar-oracle-api] [nio-8090-exec-4] c.b.g.o.service.SparBecCatalogueService  : 617925f3-0975-4f7d-a8f3-0133e68363c4 Spar BEC Catalogue entity found, returning 4 descriptions found

@RMCampos RMCampos merged commit 6b96a6e into main Jul 16, 2024
21 checks passed
@RMCampos RMCampos deleted the fix/1393-orchard-requests-taking-too-long branch July 16, 2024 18:25
mgaseta
mgaseta approved these changes Jul 16, 2024
View reviewed changes
Copy link
Collaborator

@mgaseta mgaseta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DerekRoberts DerekRoberts DerekRoberts approved these changes

@mgaseta mgaseta mgaseta approved these changes

@craigyu craigyu Awaiting requested review from craigyu

@SLDonnelly SLDonnelly Awaiting requested review from SLDonnelly SLDonnelly is a code owner

Assignees

@RMCampos RMCampos

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Orchard requests taking too long
3 participants
@RMCampos @DerekRoberts @mgaseta