Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: improve seedlot saving and audit information #1405

Merged
merged 12 commits into from
Jul 19, 2024

Conversation

RMCampos
Copy link
Contributor

@RMCampos RMCampos commented Jul 17, 2024

Description

Part of #1392

Sorry for this huge PR. It's not much actually, but since I had to deal with audit tables, most of the entities and test cases needed to be changed.

Changelog

New

  • Audit listeners for automatically usage
  • Seedlot In Memory Data to avoind fetching from Oracle twice;

Changed

  • Seedlot Service responsible for saving the seedlot a-class form submission;

Removed

  • Manual handler for the current user entry_id;

How was this tested?

  • 🧠 Not needed
  • 👀 Eyeball
  • 🤖 Added tests

What gif/image best describes this PR or how it makes you feel?


Thanks for the PR!

Deployments, as required, will be available below:

Please create PRs in draft mode. Mark as ready to enable:

After merge, new images are deployed in:

@RMCampos RMCampos self-assigned this Jul 17, 2024
@RMCampos RMCampos linked an issue Jul 17, 2024 that may be closed by this pull request
common/Dockerfile Dismissed Show dismissed Hide dismissed
@RMCampos RMCampos closed this Jul 18, 2024
@RMCampos RMCampos reopened this Jul 18, 2024
Copy link
Collaborator

@craigyu craigyu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good stuff! time saved

@RMCampos RMCampos merged commit 8d409a2 into main Jul 19, 2024
27 checks passed
@RMCampos RMCampos deleted the fix/1392-gateway-timeout-504 branch July 19, 2024 17:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Gateway timeout - 504 - Network Error Failed
3 participants