Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: 1421 refactor text #1427

Merged
merged 37 commits into from
Aug 12, 2024
Merged

feat: 1421 refactor text #1427

merged 37 commits into from
Aug 12, 2024

Conversation

ngunner15
Copy link
Collaborator

@ngunner15 ngunner15 commented Jul 22, 2024

Description

Closes #1421

Changelog

New

  • None

Changed

  • Text updates
  • Sorting checkbox alphabetically

Removed

  • None

How was this tested?

  • 🧠 Not needed
  • 👀 Eyeball
  • 🤖 Added tests

What gif/image best describes this PR or how it makes you feel?


Thanks for the PR!

Deployments, as required, will be available below:

Please create PRs in draft mode. Mark as ready to enable:

After merge, new images are deployed in:

@ngunner15 ngunner15 added refactor Refactoring implementation front-end front-end related task labels Jul 22, 2024
@ngunner15 ngunner15 self-assigned this Jul 22, 2024
@ngunner15 ngunner15 linked an issue Jul 22, 2024 that may be closed by this pull request
@ngunner15 ngunner15 changed the title Feat/1421 refactor text feat: 1421 refactor text Jul 22, 2024
@ngunner15 ngunner15 marked this pull request as ready for review July 22, 2024 20:44
@RMCampos RMCampos closed this Jul 26, 2024
@RMCampos RMCampos reopened this Jul 26, 2024
@ngunner15 ngunner15 requested a review from craigyu August 7, 2024 18:06
@craigyu
Copy link
Collaborator

craigyu commented Aug 7, 2024

your front-end build failed, please check out the error in the action run

@ngunner15 ngunner15 requested a review from craigyu August 7, 2024 23:26
@craigyu
Copy link
Collaborator

craigyu commented Aug 8, 2024

@ngunner15 your frontend build is still failing, please check the error in the action, it's not an issue with GitHub btw

@DerekRoberts
Copy link
Member

@ngunner15 your frontend build is still failing, please check the error in the action, it's not an issue with GitHub btw

@ngunner15 Try locally with cd frontend && docker build . -t frontend.

It appears to be failing during transpilation (ts -> js conversion). Looks like FavActivityType needs a description property added.

> [email protected] build
> tsc && vite build

src/config/FavouriteActivitiyMap.ts(10,5): error TS2353: Object literal may only specify known properties, and 'description' does not exist in type 'FavActivityType'.
src/config/FavouriteActivitiyMap.ts(27,5): error TS2353: Object literal may only specify known properties, and 'description' does not exist in type 'FavActivityType'.
src/config/FavouriteActivitiyMap.ts(36,5): error TS2353: Object literal may only specify known properties, and 'description' does not exist in type 'FavActivityType'.
src/config/FavouriteActivitiyMap.ts(45,5): error TS2353: Object literal may only specify known properties, and 'description' does not exist in type 'FavActivityType'.

Copy link
Collaborator

@craigyu craigyu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good work, just need to fix some components that are making build fail

@ngunner15 ngunner15 requested a review from craigyu August 9, 2024 01:06
@ngunner15
Copy link
Collaborator Author

@ngunner15 your frontend build is still failing, please check the error in the action, it's not an issue with GitHub btw

@ngunner15 Try locally with cd frontend && docker build . -t frontend.

It appears to be failing during transpilation (ts -> js conversion). Looks like FavActivityType needs a description property added.

> [email protected] build
> tsc && vite build

src/config/FavouriteActivitiyMap.ts(10,5): error TS2353: Object literal may only specify known properties, and 'description' does not exist in type 'FavActivityType'.
src/config/FavouriteActivitiyMap.ts(27,5): error TS2353: Object literal may only specify known properties, and 'description' does not exist in type 'FavActivityType'.
src/config/FavouriteActivitiyMap.ts(36,5): error TS2353: Object literal may only specify known properties, and 'description' does not exist in type 'FavActivityType'.
src/config/FavouriteActivitiyMap.ts(45,5): error TS2353: Object literal may only specify known properties, and 'description' does not exist in type 'FavActivityType'.

Thanks for the info 👍

Copy link
Contributor

@RMCampos RMCampos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ngunner15 ngunner15 enabled auto-merge (squash) August 12, 2024 15:07
@ngunner15 ngunner15 enabled auto-merge (squash) August 12, 2024 15:08
@ngunner15 ngunner15 merged commit 0ed1338 into main Aug 12, 2024
27 of 28 checks passed
@ngunner15 ngunner15 deleted the feat/1421-refactor-text branch August 12, 2024 16:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
front-end front-end related task refactor Refactoring implementation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

text update found by kevin
5 participants