Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: progress bar UI improvements #1436

Merged
merged 9 commits into from
Jul 26, 2024
Merged

feat: progress bar UI improvements #1436

merged 9 commits into from
Jul 26, 2024

Conversation

RMCampos
Copy link
Contributor

@RMCampos RMCampos commented Jul 23, 2024

Description

Closes #1434

Changelog

New

  • Icons for the Progress Bar indicator of the seedlot registration form.
  • Current step in bold

How was this tested?

  • 🧠 Not needed
  • 👀 Eyeball
  • 🤖 Added tests

What gif/image best describes this PR or how it makes you feel?


Thanks for the PR!

Deployments, as required, will be available below:

Please create PRs in draft mode. Mark as ready to enable:

After merge, new images are deployed in:

@RMCampos RMCampos self-assigned this Jul 23, 2024
@RMCampos RMCampos linked an issue Jul 23, 2024 that may be closed by this pull request
Copy link
Collaborator

@ngunner15 ngunner15 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM💯

Copy link
Collaborator

@craigyu craigyu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good stuff! we should make a PR to carbon's repo too

Copy link
Collaborator

@mgaseta mgaseta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@RMCampos RMCampos merged commit 65e2473 into main Jul 26, 2024
28 checks passed
@RMCampos RMCampos deleted the feat/spencer-progress-bar branch July 26, 2024 15:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Progressbar icon styles
5 participants