Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: orchard null bec zone code and draft timestamp #1477

Merged
merged 2 commits into from
Aug 2, 2024
Merged

fix: orchard null bec zone code and draft timestamp #1477

merged 2 commits into from
Aug 2, 2024

Conversation

craigyu
Copy link
Collaborator

@craigyu craigyu commented Aug 2, 2024 •
edited by github-actions bot
Loading

  • fixed a problem where bec zone code with null values crashes the oracle' orchard endpoint
  • update seedlot table's timestamp when draft table is updated

Thanks for the PR!

Deployments, as required, will be available below:

Please create PRs in draft mode. Mark as ready to enable:

After merge, new images are deployed in:

@craigyu craigyu self-assigned this Aug 2, 2024
@craigyu craigyu linked an issue Aug 2, 2024 that may be closed by this pull request
Update Seedlot Draft Table #1474
Closed
RMCampos
RMCampos approved these changes Aug 2, 2024
View reviewed changes
Copy link
Contributor

@RMCampos RMCampos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great catch! Good job 💯 🚀

@craigyu craigyu enabled auto-merge (squash) August 2, 2024 19:30
@craigyu
Copy link
Collaborator Author

craigyu commented Aug 2, 2024

Cypress is flaky, merging in

@craigyu craigyu disabled auto-merge August 2, 2024 20:24
@craigyu craigyu merged commit 9332655 into main Aug 2, 2024
25 of 27 checks passed
@craigyu craigyu deleted the feat/1474-update-seedlot-draft-table branch August 2, 2024 20:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RMCampos RMCampos RMCampos approved these changes

@mgaseta mgaseta Awaiting requested review from mgaseta mgaseta is a code owner

@DerekRoberts DerekRoberts Awaiting requested review from DerekRoberts DerekRoberts is a code owner

@SLDonnelly SLDonnelly Awaiting requested review from SLDonnelly SLDonnelly is a code owner

Assignees

@craigyu craigyu

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update Seedlot Draft Table
2 participants
@craigyu @RMCampos