Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(ci): consolidate oracle-api and common containers #1512

Merged
merged 7 commits into from
Aug 15, 2024

Conversation

DerekRoberts
Copy link
Member

@DerekRoberts DerekRoberts commented Aug 15, 2024

Description

There are two containers when one would do. This also simplifies deployments a bit, since the app and its init container now use the same image.

How was this tested?

  • 🧠 Not needed
  • 👀 Eyeball
  • 🤖 Added tests

What gif/image best describes this PR or how it makes you feel?


Thanks for the PR!

Deployments, as required, will be available below:

Please create PRs in draft mode. Mark as ready to enable:

After merge, new images are deployed in:

@DerekRoberts DerekRoberts self-assigned this Aug 15, 2024
@DerekRoberts DerekRoberts added the devops devops related task label Aug 15, 2024
@DerekRoberts DerekRoberts marked this pull request as ready for review August 15, 2024 18:25
Copy link
Contributor

@RMCampos RMCampos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What a great job! Gold 🏅

@DerekRoberts DerekRoberts merged commit 6949d07 into main Aug 15, 2024
24 of 26 checks passed
@DerekRoberts DerekRoberts deleted the chore/ci/rearrangeContainers branch August 15, 2024 18:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
devops devops related task
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants