Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: adjust seedlot details page #1527

Merged
merged 10 commits into from
Aug 26, 2024
Merged

Conversation

mgaseta
Copy link
Collaborator

@mgaseta mgaseta commented Aug 16, 2024

Description

Closes #NoIssue

Adjusted the buttons labels and when to display them, according with the seedlot status.
Fixed breadcrumbs for TSC admins.

Changelog

New

  • Created new utils function for seedlot pages breadcrumbs.

Changed

  • Permissions to display buttons labels on seedlot details page.

Removed

  • Repeated breadcrumbs functions.

How was this tested?

  • 🧠 Not needed
  • 👀 Eyeball
  • 🤖 Added tests

What gif/image best describes this PR or how it makes you feel?


Thanks for the PR!

Deployments, as required, will be available below:

Please create PRs in draft mode. Mark as ready to enable:

After merge, new images are deployed in:

Copy link
Contributor

@RMCampos RMCampos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@RMCampos
Copy link
Contributor

Bypassing failing Cypress tests. As discussed in the Teams Chat, a possible fix will be addressed shortly, taking in acount promise-like and callbacks inside cypress assertions (probably the root-cause of the issue).

@RMCampos RMCampos merged commit 8da7e07 into main Aug 26, 2024
23 of 25 checks passed
@RMCampos RMCampos deleted the fix/adjust-seedlot-details-page branch August 26, 2024 13:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants