Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): node-sass deprecation #1534

Merged
merged 2 commits into from
Aug 20, 2024
Merged

Conversation

DerekRoberts
Copy link
Member

@DerekRoberts DerekRoberts commented Aug 20, 2024

Description

Closes #1443

Changelog

Removed

  • node-sass, should be okay with regular sass, already included

How was this tested?

  • 🧠 Not needed
  • 👀 Eyeball
  • 🤖 Added tests

What gif/image best describes this PR or how it makes you feel?


Thanks for the PR!

Deployments, as required, will be available below:

Please create PRs in draft mode. Mark as ready to enable:

After merge, new images are deployed in:

@DerekRoberts DerekRoberts self-assigned this Aug 20, 2024
@DerekRoberts DerekRoberts added the dependencies Pull requests that update a dependency file label Aug 20, 2024
@DerekRoberts DerekRoberts marked this pull request as ready for review August 20, 2024 04:09
@RMCampos
Copy link
Contributor

A couple of thoughts:

@RMCampos
Copy link
Contributor

RMCampos commented Aug 20, 2024

Does SPAR app needs this package?

No. After running a couple of tests, running locally and making changes, changing scss files and others, no errors were found.
Also ran a build. It passed
Also ran a preview mode. All working.

So we can safely remove it.

Copy link
Contributor

@RMCampos RMCampos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@DerekRoberts DerekRoberts merged commit 17987b5 into main Aug 20, 2024
23 of 25 checks passed
@DerekRoberts DerekRoberts deleted the chore/deps/deprecation branch August 20, 2024 16:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

chore(deps): deprecation of node-sass
2 participants