Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: 1454 smp success on parent step 5 #1546

Merged
merged 56 commits into from
Oct 4, 2024

Conversation

ngunner15
Copy link
Collaborator

@ngunner15 ngunner15 commented Aug 23, 2024

Description

Closes #1454

Changelog

New

  • Parent tree part 2 cypress test

Changed

  • Update orchard, ownership, collection and interim tests to pass GitHub Actions

Removed

How was this tested?

  • 🧠 Not needed
  • 👀 Eyeball
  • 🤖 Added tests

What gif/image best describes this PR or how it makes you feel?


Thanks for the PR!

Deployments, as required, will be available below:

Please create PRs in draft mode. Mark as ready to enable:

After merge, new images are deployed in:


Thanks for the PR!

Deployments, as required, will be available below:

Please create PRs in draft mode. Mark as ready to enable:

After merge, new images are deployed in:


Thanks for the PR!

Deployments, as required, will be available below:

Please create PRs in draft mode. Mark as ready to enable:

After merge, new images are deployed in:

@ngunner15 ngunner15 added front-end front-end related task test test related task labels Aug 23, 2024
@ngunner15 ngunner15 self-assigned this Aug 23, 2024
@ngunner15 ngunner15 linked an issue Aug 23, 2024 that may be closed by this pull request
@ngunner15 ngunner15 changed the title Feat/1454 smp success on parent step 5 feat: 1454 smp success on parent step 5 Aug 23, 2024
@ngunner15 ngunner15 closed this Aug 27, 2024
@ngunner15 ngunner15 reopened this Aug 28, 2024
@ngunner15 ngunner15 marked this pull request as ready for review October 3, 2024 21:32
Copy link
Contributor

@RMCampos RMCampos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Most of the tests cases are passing now. Still need to work on the "Complete verification check", which is failing.

@ngunner15
Copy link
Collaborator Author

LGTM.

Most of the tests cases are passing now. Still need to work on the "Complete verification check", which is failing.

Will work on those in a different ticket.

@ngunner15 ngunner15 merged commit c36c8f4 into main Oct 4, 2024
27 checks passed
@ngunner15 ngunner15 deleted the feat/1454-smp-success-on-parent-step-5 branch October 4, 2024 22:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
front-end front-end related task test test related task
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SMP success on parent(Step 5, part 2) Cypress Test
2 participants