Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: tests descriptions fixed #587

Merged
merged 5 commits into from
Nov 9, 2023
Merged

fix: tests descriptions fixed #587

merged 5 commits into from
Nov 9, 2023

Conversation

ArthurEncr
Copy link
Contributor

@ArthurEncr ArthurEncr commented Oct 30, 2023

Description

Updated test descriptions to start with verbs like "should"
Fixes #561

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist

  • I have read the CONTRIBUTING doc
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have already been accepted and merged

Further comments


Thanks for the PR!

Any successful deployments (not always required) will be available below.
Backend
Frontend
Oracle-API

Once merged, code will be promoted and handed off to following workflow run.
Main Merge Workflow

@ArthurEncr ArthurEncr linked an issue Oct 30, 2023 that may be closed by this pull request
Copy link
Collaborator

@mgaseta mgaseta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Besides Craig's comments, LGTM!

@craigyu craigyu merged commit e85d91f into main Nov 9, 2023
20 checks passed
@craigyu craigyu deleted the fix/561-test-descriptions branch November 9, 2023 01:36
DerekRoberts pushed a commit that referenced this pull request May 13, 2024
* fix: tests descriptions fixed

* fix: fixing wording
DerekRoberts pushed a commit that referenced this pull request May 14, 2024
* fix: tests descriptions fixed

* fix: fixing wording
DerekRoberts pushed a commit that referenced this pull request May 14, 2024
* fix: tests descriptions fixed

* fix: fixing wording
DerekRoberts pushed a commit that referenced this pull request May 14, 2024
* fix: tests descriptions fixed

* fix: fixing wording
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Edit cypress test description
3 participants