-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/vdyp 400 grow qmd+lh #60
Conversation
# Conflicts: # vdyp-forward/src/main/java/ca/bc/gov/nrs/vdyp/forward/ForwardProcessingEngine.java # vdyp-forward/src/test/java/ca/bc/gov/nrs/vdyp/forward/GeneralForwardProcessingEngineTest.java
# Conflicts: # vdyp-forward/src/main/java/ca/bc/gov/nrs/vdyp/forward/ForwardProcessingEngine.java # vdyp-forward/src/test/java/ca/bc/gov/nrs/vdyp/forward/GeneralForwardProcessingEngineTest.java
… since only in Forward control map.
# Conflicts: # vdyp-common/src/test/java/ca/bc/gov/nrs/vdyp/common/EstimationMethodsTest.java # vdyp-common/src/test/java/ca/bc/gov/nrs/vdyp/common/ReconcilationMethodsTest.java # vdyp-vri/src/main/java/ca/bc/gov/nrs/vdyp/vri/VriStart.java # vdyp-vri/src/test/java/ca/bc/gov/nrs/vdyp/vri/VriStartTest.java
# Conflicts: # vdyp-common/src/main/java/ca/bc/gov/nrs/vdyp/application/VdypStartApplication.java # vdyp-common/src/main/java/ca/bc/gov/nrs/vdyp/common/Estimators.java # vdyp-fip/src/main/java/ca/bc/gov/nrs/vdyp/fip/FipStart.java # vdyp-forward/src/main/java/ca/bc/gov/nrs/vdyp/forward/ForwardProcessingEngine.java # vdyp-vri/src/main/java/ca/bc/gov/nrs/vdyp/vri/VriStart.java
vdyp-lib/vdyp-common/src/test/java/ca/bc/gov/nrs/vdyp/io/ZipOutputFileResolverTest.java
Outdated
Show resolved
Hide resolved
vdyp-lib/vdyp-forward/src/main/java/ca/bc/gov/nrs/vdyp/forward/Bank.java
Show resolved
Hide resolved
vdyp-lib/vdyp-forward/src/main/java/ca/bc/gov/nrs/vdyp/forward/ForwardProcessingEngine.java
Show resolved
Hide resolved
vdyp-lib/vdyp-forward/src/main/java/ca/bc/gov/nrs/vdyp/forward/ForwardProcessingEngine.java
Outdated
Show resolved
Hide resolved
vdyp-lib/vdyp-forward/src/main/java/ca/bc/gov/nrs/vdyp/forward/ForwardProcessingEngine.java
Show resolved
Hide resolved
vdyp-lib/vdyp-forward/src/main/java/ca/bc/gov/nrs/vdyp/forward/UtilizationOperations.java
Show resolved
Hide resolved
vdyp-lib/vdyp-forward/src/main/java/ca/bc/gov/nrs/vdyp/forward/UtilizationOperations.java
Outdated
Show resolved
Hide resolved
...dyp-forward/src/test/java/ca/bc/gov/nrs/vdyp/forward/CalculateQuadMeanDiameterDeltaTest.java
Show resolved
Hide resolved
vdyp-lib/vdyp-forward/src/test/java/ca/bc/gov/nrs/vdyp/forward/ForwardProcessorTest.java
Outdated
Show resolved
Hide resolved
vdyp-lib/vdyp-forward/src/test/java/ca/bc/gov/nrs/vdyp/forward/ForwardProcessorTest.java
Show resolved
Hide resolved
The comments about magic numbers and unifying some methods in UtilizationOperations are more thoughts I had while reviewing. They might make more sense to deal with more comprehensively across the code base instead of in this PR. the DQ magic number is also a bit annoying since there are so many slightly offset versions of it, should we make a constant for each or offset each from the base as it's used? |
# Conflicts: # vdyp-lib/vdyp-common/src/main/java/ca/bc/gov/nrs/vdyp/io/write/VriAdjustInputWriter.java # vdyp-lib/vdyp-common/src/main/java/ca/bc/gov/nrs/vdyp/model/BaseVdypLayer.java # vdyp-lib/vdyp-common/src/main/java/ca/bc/gov/nrs/vdyp/model/VdypLayer.java # vdyp-lib/vdyp-fip/src/main/java/ca/bc/gov/nrs/vdyp/fip/FipStart.java # vdyp-lib/vdyp-vri/src/main/java/ca/bc/gov/nrs/vdyp/vri/VriStart.java # vdyp-lib/vdyp-vri/src/test/java/ca/bc/gov/nrs/vdyp/vri/VriStartTest.java
…PUT control keys (duplication)
Quality Gate passedIssues Measures |
Implementation complete and unit testing completed up to step 6 of grow().