Feature/vdyp 400 grow qmd+lh #60
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # vdyp-forward/src/main/java/ca/bc/gov/nrs/vdyp/forward/ForwardProcessingEngine.java # vdyp-forward/src/test/java/ca/bc/gov/nrs/vdyp/forward/GeneralForwardProcessingEngineTest.java
# Conflicts: # vdyp-forward/src/main/java/ca/bc/gov/nrs/vdyp/forward/ForwardProcessingEngine.java # vdyp-forward/src/test/java/ca/bc/gov/nrs/vdyp/forward/GeneralForwardProcessingEngineTest.java
… since only in Forward control map.
# Conflicts: # vdyp-common/src/test/java/ca/bc/gov/nrs/vdyp/common/EstimationMethodsTest.java # vdyp-common/src/test/java/ca/bc/gov/nrs/vdyp/common/ReconcilationMethodsTest.java # vdyp-vri/src/main/java/ca/bc/gov/nrs/vdyp/vri/VriStart.java # vdyp-vri/src/test/java/ca/bc/gov/nrs/vdyp/vri/VriStartTest.java
# Conflicts: # vdyp-common/src/main/java/ca/bc/gov/nrs/vdyp/application/VdypStartApplication.java # vdyp-common/src/main/java/ca/bc/gov/nrs/vdyp/common/Estimators.java # vdyp-fip/src/main/java/ca/bc/gov/nrs/vdyp/fip/FipStart.java # vdyp-forward/src/main/java/ca/bc/gov/nrs/vdyp/forward/ForwardProcessingEngine.java # vdyp-vri/src/main/java/ca/bc/gov/nrs/vdyp/vri/VriStart.java
smithkm
requested changes
Sep 9, 2024
vdyp-lib/vdyp-common/src/test/java/ca/bc/gov/nrs/vdyp/io/ZipOutputFileResolverTest.java
Outdated
Show resolved
Hide resolved
vdyp-lib/vdyp-forward/src/main/java/ca/bc/gov/nrs/vdyp/forward/Bank.java
Show resolved
Hide resolved
vdyp-lib/vdyp-forward/src/main/java/ca/bc/gov/nrs/vdyp/forward/ForwardProcessingEngine.java
Show resolved
Hide resolved
vdyp-lib/vdyp-forward/src/main/java/ca/bc/gov/nrs/vdyp/forward/ForwardProcessingEngine.java
Outdated
Show resolved
Hide resolved
vdyp-lib/vdyp-forward/src/main/java/ca/bc/gov/nrs/vdyp/forward/ForwardProcessingEngine.java
Show resolved
Hide resolved
vdyp-lib/vdyp-forward/src/main/java/ca/bc/gov/nrs/vdyp/forward/UtilizationOperations.java
Show resolved
Hide resolved
vdyp-lib/vdyp-forward/src/main/java/ca/bc/gov/nrs/vdyp/forward/UtilizationOperations.java
Outdated
Show resolved
Hide resolved
...dyp-forward/src/test/java/ca/bc/gov/nrs/vdyp/forward/CalculateQuadMeanDiameterDeltaTest.java
Show resolved
Hide resolved
vdyp-lib/vdyp-forward/src/test/java/ca/bc/gov/nrs/vdyp/forward/ForwardProcessorTest.java
Outdated
Show resolved
Hide resolved
vdyp-lib/vdyp-forward/src/test/java/ca/bc/gov/nrs/vdyp/forward/ForwardProcessorTest.java
Show resolved
Hide resolved
|
The comments about magic numbers and unifying some methods in UtilizationOperations are more thoughts I had while reviewing. They might make more sense to deal with more comprehensively across the code base instead of in this PR. the DQ magic number is also a bit annoying since there are so many slightly offset versions of it, should we make a constant for each or offset each from the base as it's used? |
# Conflicts: # vdyp-lib/vdyp-common/src/main/java/ca/bc/gov/nrs/vdyp/io/write/VriAdjustInputWriter.java # vdyp-lib/vdyp-common/src/main/java/ca/bc/gov/nrs/vdyp/model/BaseVdypLayer.java # vdyp-lib/vdyp-common/src/main/java/ca/bc/gov/nrs/vdyp/model/VdypLayer.java # vdyp-lib/vdyp-fip/src/main/java/ca/bc/gov/nrs/vdyp/fip/FipStart.java # vdyp-lib/vdyp-vri/src/main/java/ca/bc/gov/nrs/vdyp/vri/VriStart.java # vdyp-lib/vdyp-vri/src/test/java/ca/bc/gov/nrs/vdyp/vri/VriStartTest.java
…PUT control keys (duplication)
|
smithkm
approved these changes
Sep 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implementation complete and unit testing completed up to step 6 of grow().