CGI file updates and gl code updates #1649

gchauhan-aot · 2024-10-22T22:30:37Z

Description

Please provide a summary of the change and the issue fixed. Please include relevant context. List dependency changes.

Fixes # (issue)

Type of change

Please delete options that are not relevant.

Bug fix (non-breaking change which fixes an issue)
New feature (non-breaking change which adds functionality)
Breaking change (fix or feature that would cause existing functionality to not work as expected)
This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

Test A
Test B

Checklist

I have read the CONTRIBUTING doc
I have performed a self-review of my own code
I have commented my code, particularly in hard-to-understand areas
I have made corresponding changes to the documentation
My changes generate no new warnings
I have added tests that prove my fix is effective or that my feature works
New and existing unit tests pass locally with my changes
Any dependent changes have already been accepted and merged

Further comments

Thanks for the PR!

Deployments, as required, will be available below:

Please create PRs in draft mode. Mark as ready to enable:

Analysis Workflow

After merge, new images are promoted to:

Merge Workflow

ORV2-1314-4: added test cases for cgi generator helper

ORV2-1314-4: to fix sonarcloud failures

ORV2-1314-4: to fix a path error

Try to fix test cases

ignore coverage for cgi generator

To fix sonarcloud alert

to fix sonarcloud alert

test

ORV2-1314-4: rework based on PR comments

Test commit

test commit 1

test commit 2

use version 34 for holiday table

test commit 3

ORV2-1314-4: deleted test cases for generator for review and merge

ORV2-1314-4: used v_35 for database change

ORV2-1314-4: corrected the version of the revert script

ORV2-1314-4: rework on review comments

test commit

ORV2-1314-4: use v_36 for holiday table

# Conflicts: # database/mssql/scripts/versions/revert/v_36_ddl_revert.sql # database/mssql/scripts/versions/v_36_ddl.sql # database/mssql/test/versions/v_36_1_test.sql # database/mssql/test/versions/v_36_test.sh # scheduler/package-lock.json # scheduler/package.json # scheduler/src/modules/cgi-sftp/cgi-sftp.service.ts

krishnan-aot · 2024-10-22T23:42:00Z

scheduler/src/common/constants/cgi.constant.ts

@@ -0,0 +1,13 @@
+export class CgiConstants {


Should these constants be env values? or is it fine as constants here?

not ready for review yet :) . created PR to test sftp in dev

krishnan-aot · 2024-10-22T23:43:10Z

scheduler/src/modules/transactions/transaction.service.ts

+            transaction.paymentMethodTypeCode,
+            transaction.paymentCardTypeCode,
+          );
+          console.log('revenueGl: ', revenueGl);


Remove console.log

not ready for review yet :) . created PR to test sftp in dev

…ch now)

sonarqubecloud · 2024-11-01T20:34:27Z

Quality Gate passed for 'onroutebc dops'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

sonarqubecloud · 2024-11-01T20:34:30Z

Quality Gate passed for 'onroutebc_policy'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

sonarqubecloud · 2024-11-01T20:34:37Z

Quality Gate passed for 'onroutebc vehicles'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

sonarqubecloud · 2024-11-01T20:34:38Z

Quality Gate failed for 'onroutebc_scheduler'

Failed conditions
1 Security Hotspot
0.0% Coverage on New Code (required ≥ 80%)
8.2% Duplication on New Code (required ≤ 3%)

See analysis details on SonarCloud

sonarqubecloud · 2024-11-01T20:35:06Z

Quality Gate passed for 'onroutebc frontend'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

bcgov-brwang and others added 30 commits July 10, 2024 18:27

ORV2-1314-4: add sql file for testing

2998571

ORV2-1314-4: generate cgi files and upload to sftp server

4811480

ORV2-1314-4: added test cases for cgi generator helper

f60ee6d

ORV2-1314-4: added test cases for cgi generator helper

ORV2-1314-4: to fix sonarcloud failures

d3063ce

ORV2-1314-4: to fix sonarcloud failures

ORV2-1314-4: to fix a path error

ad2357a

ORV2-1314-4: to fix a path error

Try to fix test cases

acbb588

Try to fix test cases

Try to fix test cases

1a7a738

Try to fix test cases

ignore coverage for cgi generator

5a8fca4

ignore coverage for cgi generator

To fix sonarcloud alert

b379758

To fix sonarcloud alert

to fix sonarcloud alert

6798dff

to fix sonarcloud alert

test

62ca01a

test

ORV2-1314-4: rework based on PR comments

170e49a

ORV2-1314-4: rework based on PR comments

Test commit

905cc02

Test commit

Test commit

8384d27

Test commit

test commit

74c5557

test commit 1

42ee3b1

test commit 1

test commit 2

344a1a8

test commit 2

Merge branch 'main' into ORV2-1314-4

6a9ba2f

use version 34 for holiday table

82722a3

use version 34 for holiday table

test commit 3

29a4e2d

test commit 3

ORV2-1314-4: deleted test cases for generator for review and merge

7444aa0

ORV2-1314-4: deleted test cases for generator for review and merge

ORV2-1314-4: used v_35 for database change

d067f0f

ORV2-1314-4: used v_35 for database change

ORV2-1314-4: corrected the version of the revert script

833f9b4

ORV2-1314-4: corrected the version of the revert script

Merge branch 'main' into ORV2-1314-4

72c0953

ORV2-1314-4: rework on review comments

cb6e84b

ORV2-1314-4: rework on review comments

test commit

4162a60

test commit

Merge branch 'main' into ORV2-1314-4

2c6b7af

ORV2-1314-4: use v_36 for holiday table

f4392e8

ORV2-1314-4: use v_36 for holiday table

formatting

2f2b38a

gchauhan-aot added dont review dont merge a branch for anything that shouldn't be merged (yet or ever) labels Oct 22, 2024

gchauhan-aot requested review from cberg-aot, john-fletcher-aot and praju-aot as code owners October 22, 2024 22:30

gchauhan-aot temporarily deployed to dev October 22, 2024 22:32 — with GitHub Actions Inactive

hardcoding vault variable for testing

4692be9

gchauhan-aot temporarily deployed to dev October 22, 2024 22:44 — with GitHub Actions Inactive

krishnan-aot reviewed Oct 23, 2024

View reviewed changes

remove gl data

7f86fc4

gchauhan-aot temporarily deployed to dev October 23, 2024 00:52 — with GitHub Actions Inactive

add reprocess flag to cfs transaction details tbl

55d1868

gchauhan-aot temporarily deployed to dev October 23, 2024 01:07 — with GitHub Actions Inactive

changes gl code filler and journal name

cd8909b

gchauhan-aot temporarily deployed to dev October 23, 2024 17:43 — with GitHub Actions Inactive

delimiter change

2e9a404

gchauhan-aot temporarily deployed to dev October 23, 2024 18:00 — with GitHub Actions Inactive

Merge remote-tracking branch 'origin/main' into ORV2-1314-4

338da8c

gchauhan-aot temporarily deployed to dev October 23, 2024 18:10 — with GitHub Actions Inactive

john-fletcher-aot added 5 commits October 25, 2024 16:10

Extract GL type and GL code type table additions (in a different bran…

07e452c

…ch now)

Merge branch 'main' into ORV2-1314-4

f1541df

Merge branch 'main' into ORV2-1314-4

d79341a

Updates based on CGI feedback tests

b70166a

Merge branch 'main' into ORV2-1314-4

249ee18

john-fletcher-aot had a problem deploying to dev November 1, 2024 20:34 — with GitHub Actions Failure

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

CGI file updates and gl code updates #1649

CGI file updates and gl code updates #1649

gchauhan-aot commented Oct 22, 2024 •

edited by github-actions bot

Loading

krishnan-aot Oct 22, 2024

gchauhan-aot Oct 23, 2024

krishnan-aot Oct 22, 2024

gchauhan-aot Oct 23, 2024

sonarqubecloud bot commented Nov 1, 2024

sonarqubecloud bot commented Nov 1, 2024

sonarqubecloud bot commented Nov 1, 2024

sonarqubecloud bot commented Nov 1, 2024

sonarqubecloud bot commented Nov 1, 2024

CGI file updates and gl code updates #1649

Are you sure you want to change the base?

CGI file updates and gl code updates #1649

Conversation

gchauhan-aot commented Oct 22, 2024 • edited by github-actions bot Loading

Description

Type of change

How Has This Been Tested?

Checklist

Further comments

krishnan-aot Oct 22, 2024

Choose a reason for hiding this comment

gchauhan-aot Oct 23, 2024

Choose a reason for hiding this comment

krishnan-aot Oct 22, 2024

Choose a reason for hiding this comment

gchauhan-aot Oct 23, 2024

Choose a reason for hiding this comment

sonarqubecloud bot commented Nov 1, 2024

Quality Gate passed for 'onroutebc dops'

sonarqubecloud bot commented Nov 1, 2024

Quality Gate passed for 'onroutebc_policy'

sonarqubecloud bot commented Nov 1, 2024

Quality Gate passed for 'onroutebc vehicles'

sonarqubecloud bot commented Nov 1, 2024

Quality Gate failed for 'onroutebc_scheduler'

sonarqubecloud bot commented Nov 1, 2024

Quality Gate passed for 'onroutebc frontend'

gchauhan-aot commented Oct 22, 2024 •

edited by github-actions bot

Loading