Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ORV2-3211 - BVT: Void not refunding the total value #1740

Merged
merged 2 commits into from
Jan 11, 2025
Merged

Conversation

glen-aot
Copy link
Collaborator

@glen-aot glen-aot commented Jan 10, 2025

Description

update calculateAmountForVoid to return full netPaid amount.

Fixes #ORV2-3211

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)

Checklist

  • I have read the CONTRIBUTING doc
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have already been accepted and merged

Thanks for the PR!

Deployments, as required, will be available below:

Please create PRs in draft mode. Mark as ready to enable:

After merge, new images are promoted to:

Copy link

Copy link

Copy link

Copy link

Copy link

Quality Gate Failed Quality Gate failed for 'onroutebc frontend'

Failed conditions
57.1% Coverage on New Code (required ≥ 80%)

See analysis details on SonarQube Cloud

@glen-aot glen-aot merged commit 4d05079 into main Jan 11, 2025
23 of 24 checks passed
@glen-aot glen-aot deleted the ORV2-3211 branch January 11, 2025 00:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants