Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move docs to OTP 27 ex_doc support #134

Merged
merged 2 commits into from
Jul 15, 2024

Conversation

whatyouhide
Copy link
Contributor

@whatyouhide whatyouhide commented Jul 10, 2024

Went ahead with this! It looks gorgeous 😉

Closes #133.

CleanShot 2024-07-10 at 18 04 14@2x

@whatyouhide whatyouhide changed the title Main docs (missing tabsets in telemetry mod) Move docs to OTP 27 ex_doc support Jul 10, 2024
josevalim
josevalim previously approved these changes Jul 10, 2024
@whatyouhide whatyouhide mentioned this pull request Jul 14, 2024
@josevalim josevalim merged commit 98714d1 into beam-telemetry:main Jul 15, 2024
5 checks passed
@josevalim
Copy link
Contributor

💚 💙 💜 💛 ❤️

@whatyouhide whatyouhide deleted the al/otp27-docs branch July 15, 2024 15:06
@whatyouhide
Copy link
Contributor Author

Thanks!! 💟

@wojtekmach
Copy link
Contributor

Sorry to be the person but can we have a new release? :) I think this is a pretty huge deal, I believe for the very first time we have shell docs out of the box (without tools like docsh) for Erlang packages. This just works:

IMG_0333

@whatyouhide
Copy link
Contributor Author

Lovely! I don't have maintainer privileges on Telemetry, I’m just a contributor so someone else will have to do 🥲

NelsonVides added a commit to esl/segmented_cache that referenced this pull request Sep 17, 2024
NelsonVides added a commit to esl/segmented_cache that referenced this pull request Sep 17, 2024
NelsonVides added a commit to esl/segmented_cache that referenced this pull request Sep 17, 2024
NelsonVides added a commit to esl/segmented_cache that referenced this pull request Sep 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

OTP 27 docs
4 participants