Fix/double asmdefs #3825
Merged
Fix/double asmdefs #3825
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # client/Packages/com.beamable.server/CHANGELOG.md
cdhanna
added a commit
that referenced
this pull request
Dec 17, 2024
* fixes #3823 and fixes #3822 (#3824) Co-authored-by: Chris Hanna <[email protected]> * Fix/double asmdefs (#3825) * Fix migrator asmdef validator * fix git ignore not existing in unity projects * Changelogs * change order of git ignore init to be consistent with other locations --------- Co-authored-by: Chris Hanna <[email protected]> * changelog and unity cli up to 3.0.2 rc1 * 2.0.1 patch (#3826) * Fix flawed websocket retry logic (#3815) * attempt to fix retry logic around websocket * we always create before we connect so move it in there * Replaced coroutineService with _coroutineService We are no longer passing in a coroutineService, so we should use _coroutineService instead, so the code compiles. * Ensure we refresh the token on retry It can be true that the websocket reconnect can happen before we make another request to refresh the token. Eventually it will refresh but adding this line here will ensure that we only get 1 websocket connection exception in that case * let the BeamableApiRequester be fetched from DI * update changelog --------- Co-authored-by: ben-beamable <[email protected]> # Conflicts: # client/Packages/com.beamable/CHANGELOG.md * fix cli release date for changelog for 3.0.2 * update cli to 3.0.2 --------- Co-authored-by: Justin LeFebvre <[email protected]> Co-authored-by: Chris Hanna <[email protected]> * changelog and minor version * better fix --------- Co-authored-by: Chris Hanna <[email protected]> Co-authored-by: gabrielbeamable <[email protected]> Co-authored-by: Justin LeFebvre <[email protected]>
cdhanna
added a commit
that referenced
this pull request
Dec 17, 2024
* fixes #3823 and fixes #3822 (#3824) Co-authored-by: Chris Hanna <[email protected]> * Fix/double asmdefs (#3825) * Fix migrator asmdef validator * fix git ignore not existing in unity projects * Changelogs * change order of git ignore init to be consistent with other locations --------- Co-authored-by: Chris Hanna <[email protected]> * changelog and unity cli up to 3.0.2 rc1 * 2.0.1 patch (#3826) * Fix flawed websocket retry logic (#3815) * attempt to fix retry logic around websocket * we always create before we connect so move it in there * Replaced coroutineService with _coroutineService We are no longer passing in a coroutineService, so we should use _coroutineService instead, so the code compiles. * Ensure we refresh the token on retry It can be true that the websocket reconnect can happen before we make another request to refresh the token. Eventually it will refresh but adding this line here will ensure that we only get 1 websocket connection exception in that case * let the BeamableApiRequester be fetched from DI * update changelog --------- Co-authored-by: ben-beamable <[email protected]> # Conflicts: # client/Packages/com.beamable/CHANGELOG.md * fix cli release date for changelog for 3.0.2 * update cli to 3.0.2 --------- Co-authored-by: Justin LeFebvre <[email protected]> Co-authored-by: Chris Hanna <[email protected]> * changelog and minor version * better fix * possible nre on beam button (#3828) Co-authored-by: Chris Hanna <[email protected]> --------- Co-authored-by: Chris Hanna <[email protected]> Co-authored-by: gabrielbeamable <[email protected]> Co-authored-by: Justin LeFebvre <[email protected]>
cdhanna
added a commit
that referenced
this pull request
Feb 13, 2025
* fixes #3823 and fixes #3822 (#3824) Co-authored-by: Chris Hanna <[email protected]> * Fix/double asmdefs (#3825) * Fix migrator asmdef validator * fix git ignore not existing in unity projects * Changelogs * change order of git ignore init to be consistent with other locations --------- Co-authored-by: Chris Hanna <[email protected]> * changelog and unity cli up to 3.0.2 rc1 * 2.0.1 patch (#3826) * Fix flawed websocket retry logic (#3815) * attempt to fix retry logic around websocket * we always create before we connect so move it in there * Replaced coroutineService with _coroutineService We are no longer passing in a coroutineService, so we should use _coroutineService instead, so the code compiles. * Ensure we refresh the token on retry It can be true that the websocket reconnect can happen before we make another request to refresh the token. Eventually it will refresh but adding this line here will ensure that we only get 1 websocket connection exception in that case * let the BeamableApiRequester be fetched from DI * update changelog --------- Co-authored-by: ben-beamable <[email protected]> # Conflicts: # client/Packages/com.beamable/CHANGELOG.md * fix cli release date for changelog for 3.0.2 * update cli to 3.0.2 --------- Co-authored-by: Justin LeFebvre <[email protected]> Co-authored-by: Chris Hanna <[email protected]> * changelog and minor version * better fix * possible nre on beam button (#3828) Co-authored-by: Chris Hanna <[email protected]> * patch 2.0.3 (#3879) * [BEAM-3843] do best try finding asmdefs (#3855) * First add fallback for posterior errors and doc * do best try finding asmdefs * Try a different approach to load asmdef assets * fix missing variable * Fix issues with different names in assembly * Add error log * Add assets to a dict * Fix other null ref * move load assemblies to other order --------- Co-authored-by: Chris Hanna <[email protected]> # Conflicts: # client/Packages/com.beamable.server/CHANGELOG.md * fixed #3865 config window gui exceptions (#3872) Co-authored-by: Chris Hanna <[email protected]> # Conflicts: # client/Packages/com.beamable.server/CHANGELOG.md * changelogs * update artifacts version * use net 8 only * pr changes --------- Co-authored-by: gabrielbeamable <[email protected]> Co-authored-by: Chris Hanna <[email protected]> --------- Co-authored-by: Chris Hanna <[email protected]> Co-authored-by: gabrielbeamable <[email protected]> Co-authored-by: Justin LeFebvre <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket
resolves #3821 #3820
Brief Description