Try using separate artifacts for reporting?

bearcove · Mar 31, 2024 · 2174d42 · 2174d42
1 parent f07552b
commit 2174d42
Show file tree

Hide file tree

Showing 2 changed files with 22 additions and 30 deletions.
diff --git a/.github/workflows/h2spec-report.yml b/.github/workflows/h2spec-report.yml
@@ -11,39 +11,17 @@ permissions:
 jobs:
   h2spec-report:
     runs-on: ubuntu-latest
+    strategy:
+      matrix:
+        suite: [h2spec-generic, h2spec-hpack, h2spec-http2]
     steps:
-      - name: Download h2spec Report
-        uses: dawidd6/action-download-artifact@v2
-        with:
-          name: h2spec-results
-          workflow: ${{ github.event.workflow.id }}
-          run_id: ${{ github.event.workflow_run.id }}
       - name: Stub Git repo for test-reporter
         run: |
           git init
       - name: Publish h2spec-generic report
-        if: success() || failure()
-        uses: dorny/test-reporter@v1
-        with:
-          name: h2spec-generic
-          path: h2spec-generic.xml
-          reporter: java-junit
-      - name: Publish h2spec-hpack report
-        if: success() || failure()
+        if: always()
         uses: dorny/test-reporter@v1
         with:
-          name: h2spec-hpack
-          path: h2spec-hpack.xml
+          name: "${{ matrix.suite }}"
+          artifact: "${{ matrix.suite }}"
           reporter: java-junit
-      - name: Publish h2spec-http2 report
-        uses: dorny/test-reporter@v1
-        if: success() || failure()
-        with:
-          name: h2spec-http2
-          path: h2spec-http2.xml
-          reporter: java-junit
-      - name: Report h2spec regressions
-        if: success() || failure()
-        uses: bearcove/report-h2spec-regressions@22403fe3e79edebe2b39068606b4cb40cf016cf7
-        with:
-          suites: "h2spec-generic,h2spec-hpack,h2spec-http2"
diff --git a/.github/workflows/test.yml b/.github/workflows/test.yml
@@ -96,11 +96,25 @@ jobs:
           file: coverage/lcov.info
       - name: Upload h2spec Report
         uses: actions/upload-artifact@v4
-        if: always() # always run even if the previous step fails
+        if: always()
         with:
-          name: h2spec-results
+          name: h2spec-generic
           path: |
             target/h2spec-generic.xml
+          retention-days: 90
+      - name: Upload h2spec Report
+        uses: actions/upload-artifact@v4
+        if: always()
+        with:
+          name: h2spec-hpack
+          path: |
             target/h2spec-hpack.xml
+          retention-days: 90
+      - name: Upload h2spec Report
+        uses: actions/upload-artifact@v4
+        if: always()
+        with:
+          name: h2spec-http2
+          path: |
             target/h2spec-http2.xml
           retention-days: 90