fix(di): typing array of elements for registry #602
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yarastqt
reviewed
Apr 12, 2021
| @@ -104,7 +104,7 @@ export interface IRegistryOptions { | |||
| const registryHocMark = 'RegistryHoc' | |||
| export type HOC<T> = (WrappedComponent: ComponentType) => ComponentType<T> | |||
|
|
|||
| type IRegistryEntity<T = any> = ComponentType<T> | IRegistryHOC<T> | |||
| type IRegistryEntity<T = any> = ComponentType<T> | ComponentType<T>[] | IRegistryHOC<T> | |||
There was a problem hiding this comment.
Привет! А можешь рассказать, в каком сценарии тебе понадобилось в реестр добавлять массив компонентов?
There was a problem hiding this comment.
Вот тут:
https://a.yandex-team.ru/review/1703329/files/2#file-0-61954334:R83
Вот на основном уровне:
https://a.yandex-team.ru/review/1703329/files/2#file-0-61954352:R12
Вот в регистре:
https://a.yandex-team.ru/review/1703329/files/2#file-0-61954355:R32
Вот эксперимент с компонентом:
https://a.yandex-team.ru/review/1703329/files/2#file-0-61954332:R22
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Добавлен тайпинг, позволяющий класть в регистр компоненты, возвращающие массив компонентов.