Source maps support #160

tadatuta · 2015-12-23T11:55:46Z

Closes #108

blond · 2015-12-23T14:54:49Z

lib/compiler.js

 var vm = require('vm');
+var SourceMap = require('enb-source-map/lib/file');


Why not File?

File says nothing about what it really does :(

tadatuta · 2016-01-16T20:00:10Z

cc @blond

tadatuta · 2016-01-18T15:26:19Z

https://github.com/bem/bem-xjst/tree/issues/108-demo/source-map-demo

blond · 2016-01-18T15:32:59Z

bin/bem-xjst

@@ -35,6 +35,13 @@ require('coa').Cmd()
        .short('e').long('engine')
        .def('bemhtml')
        .end()
+    .opt()
+        .name('sourceMap').title('Generate source map (default: false)')


Вроде все тулзы пишут в одно слово — sourcemap.

miripiruni · 2016-02-29T23:49:01Z

@tadatuta can you describe current status please? Just for log… what we have here: some blockers, next steps.

tadatuta · 2016-03-01T10:04:08Z

First some improvements in https://github.com/enb-make/enb-source-map needed (see issues list there).

miripiruni · 2016-09-12T13:58:39Z

Rebased from master.

coveralls · 2016-09-12T14:04:24Z

Coverage increased (+0.007%) to 97.04% when pulling aa6435a on issues/108 into 49a3e10 on master.

levonet added the status: review label Dec 23, 2015

tadatuta force-pushed the issues/108 branch 3 times, most recently from 1940218 to 7f07611 Compare December 23, 2015 12:13

blond reviewed Dec 23, 2015
View reviewed changes

miripiruni added the semver: minor label Dec 25, 2015

tadatuta changed the title ~~Source maps support~~ [WIP] Source maps support Jan 1, 2016

tadatuta force-pushed the issues/108 branch from 09c450d to b949d9d Compare January 16, 2016 19:52

tadatuta changed the title ~~[WIP] Source maps support~~ Source maps support Jan 16, 2016

blond reviewed Jan 18, 2016
View reviewed changes

miripiruni added the scope: debuggability label Mar 10, 2016

miripiruni force-pushed the master branch from a98cab6 to 61f56a6 Compare March 28, 2016 13:01

miripiruni force-pushed the issues/108 branch from b949d9d to 33b8489 Compare September 12, 2016 13:56

Source maps support

aa6435a

miripiruni force-pushed the issues/108 branch from 33b8489 to aa6435a Compare September 12, 2016 13:58

miripiruni added status: in progress and removed status: review labels Sep 12, 2016

miripiruni force-pushed the master branch from fe64f93 to 79b3e4e Compare December 2, 2016 12:36

miripiruni closed this Apr 26, 2017

miripiruni removed the status: in progress label Apr 26, 2017

miripiruni mentioned this pull request May 17, 2017

Source map support (issue #108) #454

Merged

miripiruni deleted the issues/108 branch January 29, 2018 11:09

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Source maps support #160

Source maps support #160

tadatuta commented Dec 23, 2015

blond Dec 23, 2015

tadatuta Dec 23, 2015

tadatuta commented Jan 16, 2016

tadatuta commented Jan 18, 2016

blond Jan 18, 2016

miripiruni commented Feb 29, 2016

tadatuta commented Mar 1, 2016

miripiruni commented Sep 12, 2016

coveralls commented Sep 12, 2016 •

edited

Loading

		var vm = require('vm');
		var SourceMap = require('enb-source-map/lib/file');

Source maps support #160

Source maps support #160

Conversation

tadatuta commented Dec 23, 2015

blond Dec 23, 2015

Choose a reason for hiding this comment

tadatuta Dec 23, 2015

Choose a reason for hiding this comment

tadatuta commented Jan 16, 2016

tadatuta commented Jan 18, 2016

blond Jan 18, 2016

Choose a reason for hiding this comment

miripiruni commented Feb 29, 2016

tadatuta commented Mar 1, 2016

miripiruni commented Sep 12, 2016

coveralls commented Sep 12, 2016 • edited Loading

coveralls commented Sep 12, 2016 •

edited

Loading