Add ext_iterator_interface_compat, a portable alternative to iterator_interface.
#13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
camio
changed the title
Added a build option, BEMAN_ITERATOR_INTERFACE26_USE_DEDUCING_THIS, that switches between the deducing this implementation and that used by stl_interfaces. It defaults to whether the compiler supports deducing this. This element of configuration is placed in a generated config.hpp. This was chosen, as opposed to using a define passed as a compiler flag, to avoid ODR violations with larger projects with incoherent flag usage. The `iterator_interface_access` struct was moved to its own header since it is needed by both the deducing this and stl_interfaces implementations. The stl_interfaces implementation was modifed to use this so it better conforms to the paper. Some cleanup is still needed before this gets merged in: - There are optional26 remnants where stl_interfaces was brought in from. - Documentation is needed to explain when the extra template parameter is required. BEMAN_ITERATOR_INTERFACE26_USE_DEDUCING_THIS() should probably also be mentioned in that context. The intent is to address these once the overall approach has consensus. Fixes bemanproject#10 and depends on bemanproject#12.
camio
force-pushed
the
add-cpp20-support
branch
from
843054c to
8cf8b53
Compare
neatudarius
reviewed
Oct 21, 2024
This fixes an issue where testing wasn't enabled by default. I followed the suggestion made at bemanproject/exemplar#60 (comment)
This is more ergonomic than having two different versions of interator_interface without having different names.
camio
changed the title
camio
changed the title
camio
changed the title
iterator_interface.
camio
changed the title
iterator_interface.ext_iterator_interface_compat, a portable alternative to iterator_interface.
steve-downey
approved these changes
Nov 7, 2024
There was a problem hiding this comment.
I don't think this was part of this change, but
https://github.com/beman-project/iterator_interface/pull/13/files#diff-7d7f79f7e81b3a5127eb407b43c39c90befb00593ef4d6721ee28edf4e87f9f9R179-R184
is now generating a dangling temporary warning?
Added #15 to address this. I couldn't figure out the cause with an initial look. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
iterator_interfaceclass template requires deducing *this support which came in C++23 and is not yet widely available. This PR introduces an alternative class templateext_iterator_interface_compatwhich requires an additional template argument (for RAII support), but otherwise has the same functionality ofiterator_interfacewithout the deducing *this dependency.ext_to make it clear that this is an extension to theiterator_interfacepaper. It may be interesting to adopt this as a convention for Beman libraries in general.BEMAN_ITERATOR_INTERFACE26_USE_DEDUCING_THIS, thatindicates whether deducing *this is available. This element of configuration is placed in a generated
config.hpp. This was chosen, as opposed to using a define passed as a compiler flag, to avoid ODR violations with larger projects with incoherent flag usage.ext_iterator_interface_compatis implemented withiterator_interface. If it is not available, instantiation ofiterator_interfaceresults in a helpful error message andext_interator_interface_compatis implemented using an in-source copy ofBoost.Stl_Interfaceswith the following modifications:beman::iterator_interface26::iterator_interface_accessfor access control for consistency.The intent is to add documentation in a separate PR once this gets moved in.
Fixes #10.