Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test the testing framework #6

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Conversation

robert-andrzejuk
Copy link
Collaborator

No description provided.


#include <gtest/gtest.h>


Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[pre-commit] reported by reviewdog 🐶

Suggested change

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we use this one instead: https://github.com/boost-ext/ut

I don't care for gtest and have had good experience with this one. Note that since Boost.ut is a single header we can avoid all the package issues by simplying copying into our repo while all the cmake stuff gets figured out.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know this framework, but after a short look at the documentation, I don't have a problem with it.
As long as we have someone who can help resolve any issues, then no problem.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I use it extensively so I can help -- but you won't need it -- it just works.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My $0.02 is who writes the tests decide which testing framework to use.

There has been a lot of talks in beman about moving to a shining new testing framework from Google Test (lit, ut, you name it), but right now no actual project is using anything other than Google Test or a single executable with bunch of static_asserts.

I think if @JeffGarland want us to use ut, @JeffGarland should submit a PR with some test cases to start us off. I can help with the setup.

The same arguments applies for @robert-andrzejuk , I think initial tests and the test framework should be packed into a single PR.

Copy link
Member

@JeffGarland JeffGarland Feb 8, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can most certainly submit a PR, but if I do that I think we wouldn't need this one. I'm going to be on airplanes for the next 24 hours -- and jet lagged after that -- so relying on me in the short run would mean no progress for a couple days likely. gtest can most certainly be replaced later as well -- but time spent get it said up will just be wasted.

Meanwhile one could take 10 minutes -- copy the boost.ut header into the test directory and write a test -- the hello world for boost.ut isn't complicated in the least

https://godbolt.org/z/czTrKzo8Y

Sorry, gotta catch a plane -- have fun!

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Alright! Noted, good luck!

@robert-andrzejuk robert-andrzejuk changed the title Test the testing the testing framework Test the testing framework Feb 7, 2025
@robert-andrzejuk
Copy link
Collaborator Author

I tried to have a look at ut, but I had issues: boost-ext/ut#662
I haven't recieved any info back, what is wrong.

So in the mean time I configured Catch2.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants