Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

widen key constraint to 'any' for a standard map #26

Closed
wants to merge 1 commit into from

Conversation

laher
Copy link
Contributor

@laher laher commented Nov 4, 2022

This adjustment in response to #25

I went ahead and changed the key constraint to any for a non-sorted Map, and it turned out to be much less work than I expected, particularly because you can bring your own Hasher.

  • In the interest of my sanity I also moved the sorted map into a separate file.
  • I don't know how well this works, I just worked on it until it complied and tests passed.
  • I only had to change one func body here - func ( h *defaultHasher[K]).Equal(a, b K). Seems fine I think

@laher
Copy link
Contributor Author

laher commented Dec 4, 2022

superceded by #29

@laher laher closed this Dec 4, 2022
@laher laher deleted the map-any-key branch December 4, 2022 08:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant