Added QueuedConsumer implementation #65
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…with and async for.
|
I think this is a little too much to even view at a time. I will split up the Python3.5 and only create a PR for Python3.4 (with tests) later. |
| yield from self._consumer.cancel() | ||
|
|
||
|
|
||
| class QueuedConsumer: |
There was a problem hiding this comment.
I wonder if it might make sense to make this class inherit asyncio.Queue, rather than just wrapping it. Then you'd get all of Queue's methods 'for free' (in particular I think get_nowait might be useful). What do you think?
|
Regarding testing 3.5-specific functionality - you should be able to just make a test which runs only in 3.5. if PY35:
class WhenTestingPython35SpecificFunctionality:
... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With Python3.5 support for async with and async for.
NOTE: There are no tests for it. Can't wrap my head around how to implement a separate test for python35, any suggestions?