Remove QueuedReader and fix method cancellation #70
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As I stated in #52 fixing the cancellation issue without removing
reader
is too hard.I've gone through the code base. The
Reader
is responsible for synchronous consumption of frames, but there is No need for that if we just maintain the code correctly:Synchroniser.await
should be called right aftersender.send_*
method. At least it should not containyield from
calls in between.In
asyncio
we already have the loop, which has a great scheduling machinery, that will guaranty sequential call order.