Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Locations should be an array #13

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

axos88
Copy link

@axos88 axos88 commented Nov 3, 2014

!!! BREAKING CHANGE

Locations and try_files are made into an array.
Configuration files will need to be adjusted.

    locations:
      - name: /
        try_files:
          - $uri
          - $uri/
          - /index.html
      - name: /images/
        try_files:
          - $uri
          - $uri/
          - /index.html

@axos88 axos88 force-pushed the locations_should_be_an_array branch from a1dedba to 3a519cf Compare November 4, 2014 04:47
@axos88
Copy link
Author

axos88 commented Nov 4, 2014

Hmm... In the end I think not only try_files should be treated separately, but almost any param given to locations - if an array - should be joined using spaces.

@axos88
Copy link
Author

axos88 commented Nov 4, 2014

What do you think?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant